608474 - Test suite: ecma3 test cases use AS3 constructs

Status: VERIFIED FIXED

(Tamarin Graveyard :: Tools, defect, P3)

Description

[Lars T Hansen]

Specifically:

- Array/bug_535446.as has classes, namespaces, packages
- GlobalObject/parseFloat_513018.as has import, packages
- ObjectObjects/class_006.as has import
- RegExp/eregress_122076.as has classes
- Statements/e12_6_3_12.as has classes
- String/e15_5_3_2_1.as has 'use namespace AS3'
- String/e15_5_4_6_2_rt.as has 'use namespace AS3'
- String/localeCompare_585791.as has import, packages

Most of those uses appear gratuitous and can probably be fixed.  The rest should be moved into the as3/ test suite.

(In case anyone wonders, this causes pain for eval testing, since eval does not understand much as3 yet.  But we've discussed the problem in the past and the conclusion was that tests that use as3 constructs go into the as3 test suite.  For that reason there's as3/Array, for example, even though there's also an ecma3/Array.)

Comment 1

[Lars T Hansen]

- Expressions/e11_2_2_1.as classes, namespaces
- Expressions/e11_2_4.as has classes
- Expressions/e11_4_3.as has classes
- Expressions/e11_9_4.as has classes
- Expressions/e11_9_5.as has classes

Comment 2

[Chris Peyer]

Attachment: Update testsuite to not have as3 constructs in ecma3 dir

Modified these tests to not have as3 constructs:

test/acceptance/ecma3/ObjectObjects/class_006.as
test/acceptance/ecma3/String/e15_5_3_2_1.as
test/acceptance/ecma3/String/e15_5_4_6_2_rt.as

The following tests (and support files) were moved from ecma3 to as3:

test/acceptance/as3/Array/bug_535446.as
test/acceptance/as3/Expressions/e11_2_2_1.as
test/acceptance/as3/Expressions/e11_2_4.as
test/acceptance/as3/Expressions/e11_4_3.as
test/acceptance/as3/Expressions/e11_9_4.as
test/acceptance/as3/Expressions/e11_9_5.as
test/acceptance/as3/GlobalObject/parseFloat_513018.as
test/acceptance/as3/GlobalObject/parseFloat_513018.as.avm_args
test/acceptance/as3/RegExp/eregress_122076.as
test/acceptance/as3/Statements/e12_6_3_12.as
test/acceptance/as3/String/localeCompare_585791.as
test/acceptance/as3/String/localeCompare_585791.as.avm_args

Paths in testconfig.txt refering to the relocated files were also updated from ecma3 to as3.

Comment 3

[Brent Baker]

Comment on attachment 528757 [details] [diff] [review]
Update testsuite to not have as3 constructs in ecma3 dir

I see nothing wrong with the patch, and renamed files that were tracked in the testconfig/failconfig files have been updated.

Comment 4

[Tamarin Bot]

changeset: 6251:9efb535a268d
user:      Chris Peyer <[e-mail]>
summary:   Bug 608474: move as3 constructs out of ecma3 test dir (r=brbaker)

http://hg.mozilla.org/tamarin-redux/rev/9efb535a268d

Comment 5

[Lars T Hansen]

ecma3/Array still contains sortOn tests, for one thing.

I am most concerned about syntactic issues, which are supposedly fixed, so I'm OK with leaving this bug closed, I just wanted to note that there still is a general intermingling of tests in the test suite.