Test suite: ecma3 test cases use AS3 constructs

VERIFIED FIXED in Q3 11 - Serrano

Status

defect
P3
minor
VERIFIED FIXED
9 years ago
8 years ago

People

(Reporter: lhansen, Assigned: cpeyer)

Tracking

unspecified
Q3 11 - Serrano
Dependency tree / graph
Bug Flags:
flashplayer-qrb +

Details

Attachments

(1 attachment)

Reporter

Description

9 years ago
Specifically:

- Array/bug_535446.as has classes, namespaces, packages
- GlobalObject/parseFloat_513018.as has import, packages
- ObjectObjects/class_006.as has import
- RegExp/eregress_122076.as has classes
- Statements/e12_6_3_12.as has classes
- String/e15_5_3_2_1.as has 'use namespace AS3'
- String/e15_5_4_6_2_rt.as has 'use namespace AS3'
- String/localeCompare_585791.as has import, packages

Most of those uses appear gratuitous and can probably be fixed.  The rest should be moved into the as3/ test suite.

(In case anyone wonders, this causes pain for eval testing, since eval does not understand much as3 yet.  But we've discussed the problem in the past and the conclusion was that tests that use as3 constructs go into the as3 test suite.  For that reason there's as3/Array, for example, even though there's also an ecma3/Array.)
Reporter

Comment 1

9 years ago
- Expressions/e11_2_2_1.as classes, namespaces
- Expressions/e11_2_4.as has classes
- Expressions/e11_4_3.as has classes
- Expressions/e11_9_4.as has classes
- Expressions/e11_9_5.as has classes

Updated

9 years ago
Depends on: 508316

Updated

9 years ago
Flags: flashplayer-qrb?

Updated

9 years ago
Assignee: nobody → cpeyer
Severity: normal → minor
Status: NEW → ASSIGNED
Flags: flashplayer-qrb? → flashplayer-qrb+
Priority: -- → P3
Target Milestone: --- → flash10.x-Serrano
Assignee

Comment 2

8 years ago
Modified these tests to not have as3 constructs:

test/acceptance/ecma3/ObjectObjects/class_006.as
test/acceptance/ecma3/String/e15_5_3_2_1.as
test/acceptance/ecma3/String/e15_5_4_6_2_rt.as

The following tests (and support files) were moved from ecma3 to as3:

test/acceptance/as3/Array/bug_535446.as
test/acceptance/as3/Expressions/e11_2_2_1.as
test/acceptance/as3/Expressions/e11_2_4.as
test/acceptance/as3/Expressions/e11_4_3.as
test/acceptance/as3/Expressions/e11_9_4.as
test/acceptance/as3/Expressions/e11_9_5.as
test/acceptance/as3/GlobalObject/parseFloat_513018.as
test/acceptance/as3/GlobalObject/parseFloat_513018.as.avm_args
test/acceptance/as3/RegExp/eregress_122076.as
test/acceptance/as3/Statements/e12_6_3_12.as
test/acceptance/as3/String/localeCompare_585791.as
test/acceptance/as3/String/localeCompare_585791.as.avm_args

Paths in testconfig.txt refering to the relocated files were also updated from ecma3 to as3.
Attachment #528757 - Flags: review?(brbaker)

Comment 3

8 years ago
Comment on attachment 528757 [details] [diff] [review]
Update testsuite to not have as3 constructs in ecma3 dir

I see nothing wrong with the patch, and renamed files that were tracked in the testconfig/failconfig files have been updated.
Attachment #528757 - Flags: review?(brbaker) → review+

Comment 4

8 years ago
changeset: 6251:9efb535a268d
user:      Chris Peyer <cpeyer@adobe.com>
summary:   Bug 608474: move as3 constructs out of ecma3 test dir (r=brbaker)

http://hg.mozilla.org/tamarin-redux/rev/9efb535a268d
Assignee

Updated

8 years ago
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Assignee

Updated

8 years ago
Status: RESOLVED → VERIFIED
Reporter

Comment 5

8 years ago
ecma3/Array still contains sortOn tests, for one thing.

I am most concerned about syntactic issues, which are supposedly fixed, so I'm OK with leaving this bug closed, I just wanted to note that there still is a general intermingling of tests in the test suite.
You need to log in before you can comment on or make changes to this bug.