608657 - Remove misplaced and rapidly becoming unused "network.hosts.(pop|smtp)_server" prefs

Status: RESOLVED FIXED

(Core :: Preferences: Backend, defect)

Description

[Phil Ringnalda (:philor)]

Attachment: rm

network.hosts.smtp_server was used in nsMessengerMigration as recently as 1.8, though not in 1.9 or in the final comm-central version before it was removed.

network.hosts.pop_server is still "used" in Tb's nsDogbertProfileMigrator (assuming that still actually works), but we override all.js's attempt to set it per-platform by having a single value for it in all-thunderbird.js (a value which should be removed as part of the followup pref-killing for  bug 608638).

But for as long as mailnews.js has existed, there hasn't been any reason for either one to be in all.js, and there's no need to stick them anywhere else before removing them.

Comment 1

[Phil Ringnalda (:philor)]

Comment on attachment 487285 [details] [diff] [review]
rm

Risk: absolutely zero, never used by anything but mailnews, even back into Classic, and no longer used by any mailnews code.

Reward: I won't be able to bring this bug up while arguing that we don't have a trunk, only a relbranch named mozilla-central :)

Comment 2

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/mozilla-central/rev/fac16ef39a80