Closed Bug 608638 Opened 11 years ago Closed 11 years ago

Get rid of the Netscape 4.x profile migration

Categories

(Thunderbird :: Migration, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.3a1

People

(Reporter: philor, Assigned: philor)

References

Details

Attachments

(1 file)

Attached patch Fix v.1Splinter Review
Odds are fair that it's broken.

We know it's crashy, since the only evidence we have of anyone using it in living memory was bug 458973.

We know having it in the wizard is a trap for the unwary, from bug 432850.

It's probably even more broken in localized builds, since http://mxr.mozilla.org/l10n-mozilla1.9.2/search?string=maildirname doesn't really look like the notes for mailDirName and newsDirName were sufficient to explain that you needed to install 4.5 and 4.7 on all platforms in your locale (a bit of a (pointless) challenge since 4.x was PPC pre-OS X, so the one place that we know that mailDirName mattered, JA Mac, there is zero possibility of a direct migration from Netscape 4.x to Tb 3.next, but determining how to make migration work for someone who manually copied around a profile would require buying a computer which is no longer for sale) and determine what localized name or names they used.

Having it around has four effects on us that I can see:

* we have to do tree-wide changes to untested and untestable code
* things like Coverity are checking untested, untestable, probably unused code
* it confuses us, because we continually think that we already removed it
* it keeps alive long-dead and always-dead prefs in mailnews.js and all-thunderbird.js, because it confuses us into thinking that things like mail.server_type are not totally unused
Attachment #487262 - Flags: review?(bugzilla)
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #487262 - Flags: review?(bugzilla) → review+
http://hg.mozilla.org/comm-central/rev/5f559a9ea61d
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a1
You need to log in before you can comment on or make changes to this bug.