608774 - In Panorama mode, Ctrl+W doesn't care which group has "focus"

Status: RESOLVED DUPLICATE of bug 587276

(Firefox Graveyard :: Panorama, defect, P3)

Description

[Daniel Holbert [:dholbert]]

STEPS TO REPRODUCE:
 1. Create two tab groups, each with a bunch of tabs.
 2. Enter Panorama mode (if you aren't already there)
 3. Type Ctrl+W (or Cmd+W on a mac) and see which group loses a tab.
 4. Resize or moving the other tab group, to give it "focus" (darker border/shadow)
 5. Type Ctrl+W again and see which group loses a tab.

ACTUAL RESULTS:
 - The same tab group loses a tab in step 3 & step 5. (Ctrl+W doesn't follow your "focus")

EXPECTED RESULTS:
 - Ctrl+W should either do nothing in Panorama mode, OR it should follow your "group focus"


NOTES:
 - Currently, Ctrl+W seems to sequentially close each of the tabs in your last active group, apparently in the same order that it would be closing them if you weren't in Panorama mode. (i.e. it closes the most-recently-viewed tab first, followed by the tab to its right, etc)
 - Once your last active tab group is emptied, it switches to some other tab group (which may or may not be your currently "focused" group) and it empties that one tab-by-tab.

Comment 1

[Daniel Holbert [:dholbert]]

Note that the Panorama key combination -- Ctrl/Cmd + E -- respects the "group focus".  i.e. it opens whichever tab group has the darker border/shadow.

Ctrl/Cmd + W, on the other hand, does not respect the "group focus".  That's the bug here.

Comment 2

[Daniel Holbert [:dholbert]]

(In reply to comment #0)
> EXPECTED RESULTS:
>  - Ctrl+W should either do nothing in Panorama mode, OR it should follow your
> "group focus"

FWIW, my personal preference would be for Ctrl+W to be completely disabled in panorama mode, since (even if it followed group focus) it's not immediately clear to the user **which tab** Ctrl+W will close, in whichever group it acts upon.

If a user wants to close tabs in Panorama mode, they can already click the "x" on individual tabs, or even close an entire tab-group at once.  I'm afraid that Ctrl+W in Panorama is a bit of a foot-gun.

Comment 3

[Raymond Lee [:raymondlee]]

Assigning to Aza for the behaviour spec

Comment 4

[Ian Gilman [:iangilman]]

Actually, ctrl+w isn't supposed to work in Panorama. See bug 579199 for discussion. Bug 587276 should fix it.

Comment 5

[Daniel Holbert [:dholbert]]

> Actually, ctrl+w isn't supposed to work in Panorama.
Good - that's what I was hoping. :)

Comment 6

[Kevin Hanes]

bug spam (moving to b10)

Comment 7

[Kevin Hanes]

bug spam

Comment 8

[Aza Raskin [:aza]]

Assigning to Raymond as he is also assigned to 587276.