608789 - archive doesn't select the right message after archive finished

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[David :Bienvenu]

regression from bug 517514 - patch upcoming.

Comment 1

[David :Bienvenu]

Attachment: proposed fix

Comment 2

[Phil Ringnalda (:philor)]

Comment on attachment 487378 [details] [diff] [review]
proposed fix

Looks good, thanks!

Comment 3

[David :Bienvenu]

Attachment: add to mozmill tests to detect this bug.

Phil, I'm not sure if you review mozmill tests - if not, feel free to redirect this at Standard8. Thx!

Comment 4

[David :Bienvenu]

fixed on trunk - http://hg.mozilla.org/comm-central/rev/2df88f67953e

Comment 5

[Phil Ringnalda (:philor)]

Comment on attachment 487415 [details] [diff] [review]
add to mozmill tests to detect this bug.

Sadly, no - I failed to get them working at all in two or three OSes and VMs, and then I got tired.

Comment 6

[Mark Banner (:standard8)]

Comment on attachment 487415 [details] [diff] [review]
add to mozmill tests to detect this bug.

>+function test_selection_after_archive() {
...
>+  archive_selected_messages();
>+  assert_selected_and_displayed(hdrToSelect);
>+
>+}

nit: we don't need the extra blank line.

Comment 7

[David :Bienvenu]

mozmill test checked in.

Comment 8

[Ludovic Hirlimann [:Usul]]

Might be interesting to take this fix on the branch.