Closed Bug 608789 Opened 11 years ago Closed 11 years ago

archive doesn't select the right message after archive finished

Categories

(Thunderbird :: Folder and Message Lists, defect)

defect
Not set
normal

Tracking

(thunderbird3.1 wontfix)

RESOLVED FIXED
Thunderbird 3.3a1
Tracking Status
thunderbird3.1 --- wontfix

People

(Reporter: Bienvenu, Assigned: Bienvenu)

References

Details

(Keywords: dogfood)

Attachments

(2 files)

regression from bug 517514 - patch upcoming.
OS: Windows 7 → All
Hardware: x86 → All
Version: 3.0 → Trunk
Attached patch proposed fixSplinter Review
Attachment #487378 - Flags: review?(philringnalda)
Flags: blocking-thunderbird-next+
Keywords: dogfood
Comment on attachment 487378 [details] [diff] [review]
proposed fix

Looks good, thanks!
Attachment #487378 - Flags: review?(philringnalda) → review+
Phil, I'm not sure if you review mozmill tests - if not, feel free to redirect this at Standard8. Thx!
Attachment #487415 - Flags: review?(philringnalda)
fixed on trunk - http://hg.mozilla.org/comm-central/rev/2df88f67953e
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a1
Comment on attachment 487415 [details] [diff] [review]
add to mozmill tests to detect this bug.

Sadly, no - I failed to get them working at all in two or three OSes and VMs, and then I got tired.
Attachment #487415 - Flags: review?(philringnalda) → review?(bugzilla)
Comment on attachment 487415 [details] [diff] [review]
add to mozmill tests to detect this bug.

>+function test_selection_after_archive() {
...
>+  archive_selected_messages();
>+  assert_selected_and_displayed(hdrToSelect);
>+
>+}

nit: we don't need the extra blank line.
Attachment #487415 - Flags: review?(bugzilla) → review+
mozmill test checked in.
Flags: in-testsuite+
Might be interesting to take this fix on the branch.
You need to log in before you can comment on or make changes to this bug.