609021 - Moving Adblock Plus to "complete" impossible (out of memory error)

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P2)

Description

[Wladimir Palant]

I am trying to release Adblock Plus 1.3. As usually, this is fun. I uploaded the file twice so far, when I choose to mark it as "complete" the process hangs. In particular, these two requests (corresponding with the two files I uploaded) result in "500 Internal Server Error":

https://addons.mozilla.org/en-US/developers/json/complete/update/adblockplus-1.3.xpi
https://addons.mozilla.org/en-US/developers/json/complete/update/12795300%201288715317.xpi

The exact request and response headers:

GET /en-US/developers/json/complete/update/adblockplus-1.3.xpi HTTP/1.1
Host: addons.mozilla.org
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12
Accept: text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8
Accept-Language: en-us,en;q=0.5
Accept-Encoding: gzip,deflate
Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.7
Keep-Alive: 115
Connection: keep-alive
Cookie: <snipped>
Cache-Control: max-age=0

HTTP/1.0 500 Internal Server Error
Server: Apache
X-Backend-Server: pm-app-amo25
Cache-Control: no-cache
Content-Type: text/html; charset=UTF-8
X-amo-darklaunch: z
P3P: CP="NOI ADM DEV PSAi COM NAV OUR OTRo STP IND DEM"
Date: Tue, 02 Nov 2010 16:37:16 GMT
X-AMO-ServedBy: pm-app-amo25.mozilla.org
Via: Moz-Cache-ams-zlb01
Connection: close
X-Powered-By: PHP/5.2.9
Content-Length: 0

The file I am trying to upload is https://hg.adblockplus.org/downloads/rawfile/tip/adblockplus-1.3.xpi. Please don't push it to complete when you fix the issue - I need to release two other extensions simultaneously.

Comment 1

[Wil Clouser [:clouserw]]

I pushed a fix for this in r76702 and krupa is going to verify it on preview in about 15 minutes.  We have a push next tuesday, but if you need this sooner I'll push it out today.

Comment 2

[krupa raj[:krupa]]

I was able to update extension versions in preview without any issues. Tried this with Adblock[1865], test add-on[228515] and a search tool.

I have deleted the Adblock version I uploaded.

Calling this verified.

Comment 3

[Wladimir Palant]

(In reply to comment #1)
> but if you need this sooner I'll push it out today.

Yes, please do.

Comment 4

[Wil Clouser [:clouserw]]

(In reply to comment #3)
> (In reply to comment #1)
> > but if you need this sooner I'll push it out today.
> 
> Yes, please do.

Sure thing, bug 609137

Comment 5

[Wladimir Palant]

Thank you, I was able to mark the upload as complete successfully.