Closed Bug 609091 Opened 14 years ago Closed 6 years ago

Optimize RegExpObject::replace and String::createUTF8 for 8-bit strings

Categories

(Tamarin Graveyard :: Virtual Machine, defect)

Product:
Tamarin Graveyard
Component:
Virtual Machine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED WONTFIX
Milestone:
Future

People

(Reporter: wsharp, Unassigned)

References

Details

(Whiteboard: PACMAN)

If RegExp::replace starts with valid UTF8 strings, we should be able to skip our _analyzeUtf8 in createUTF8? (or if they 7bit to begin with?) Also, if createString calls _analyzeUTF8 and all our characters are 7bit (width.7bit=len), shouldn't our createDynamic loop at the bottom be able to just do a simply memcpy? Making these two changes drops our sunspider-0.9.1/typed/string-unpack-code.abc test case from 5.3 to 3.3 seconds.
Whiteboard: PACMAN
Blocks: regex-upgrade
Flags: flashplayer-qrb+
Target Milestone: --- → Future
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.