609164 - We should retain user formatting (line breaks) for privacy policy and EULA

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P3)

Description

[krupa raj[:krupa]]

Attachment: screenshot

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12

steps to reproduce:
1. Add three paragraphs of content(formatted with spacing and what not) as privacy policy/EULA to some add-on. 

2. Navigate to the privacy policy page- https://addons.allizom.org/z/en-US/firefox/addon/182409/privacy/ and EULA page- https://addons.allizom.org/z/en-US/firefox/addon/182409/eula/92421?src=addondetail

expected result: 
User formatting is retained without the user having to use html

actual result:
All user formatting is lost.

Also:

We save user formatting on custom license- https://addons.allizom.org/z/en-US/firefox/addon/182409/license/20100621

Comment 1

[Dave Garrett]

Yeah, I recently updated my privacy policy for Flagfox and it's all one giant blob that's kind of a mess. (on production server)

(In reply to comment #0)
> User formatting is retained without the user having to use html

I don't think HTML is allowed here. At least it says it doesn't.

Comment 2

[Dave Garrett]

What's the ETA on getting someone to fix this? I should be a quick fix (I hope) and as of right now my current privacy policy is hard to read because of this. I make a point of trying to handle privacy correctly and have my new policy divided into 4 sections that are all smushed together right now.
https://addons.allizom.org/en-US/firefox/addon/flagfox/privacy/
(I'm sticking a link to it in the URL field because the current one is 404)

By the way, this bug isn't "[ddn]" (design decision needed) as the line breaks are clearly saved and shown correctly when editing in the developer hub. They're just not respected when showing on the public page.
https://addons.allizom.org/en-US/developers/addon/edit/5791/descriptions

Comment 3

[Wil Clouser [:clouserw]]

(In reply to comment #2)
> What's the ETA on getting someone to fix this? I should be a quick fix (I hope)

It's schedule for the next milestone.  5.12.6 freezes on friday, 5.12.7 is next.  See https://mail.mozilla.com/home/[e-mail]/AMO%20Schedule.html

Comment 4

[Dave Garrett]

(In reply to comment #3)
This bug has had its target milestone bumped up twice, totaling 4 milestones. Until someone is assigned this bug, unfortunately, the milestone means nothing.

Comment 5

[Wil Clouser [:clouserw]]

(In reply to comment #4)
> (In reply to comment #3)
> This bug has had its target milestone bumped up twice, totaling 4 milestones.
> Until someone is assigned this bug, unfortunately, the milestone means nothing.

><

Comment 6

[Jeff Balogh (:jbalogh)]

qa: Make sure we don't lose any content when saving strings that allow html formatting.

Comment 7

[Gregory Koberger (:gkoberger)]

QA: The goal is to get the output as close to what the user enters as possible- it's supposed to strip out excessive newlines where they shouldn't be.  Make sure you test with lots of HTML- specifically, block level elements (<ul>, <li>, <blockquote>, etc).  Also watch for HTML attributes and unicode.

Feel free to ask me (gkoberger on #amo) if you have any questions.

If you need test case ideas, you can get lots of inspiration here:
https://github.com/jbalogh/zamboni/commit/f9d8328ad29b14f3d82e060a60811fa6357e7d82#L2R318

Commit: https://github.com/jbalogh/zamboni/commit/f9d8328ad29b14f3d82e060a60811fa6357e7d82

Comment 8

[krupa raj[:krupa]]

moving to 5.12.12, so that it can get some QA.

Comment 9

[Dave Garrett]

Thank you so much for fixing this. My privacy policy is actually readable now. Verified fixed using:
https://addons.allizom.org/en-US/firefox/addon/flagfox/privacy/

See also bug 510381. There's no need for a box to put the privacy policy or EULA text in. The license page doesn't do this and looks much better, makes better usage of available space, and makes it easier to read. For example, my privacy policy could fit on screen all at once, but instead you have to scroll through the little text box to read it.

Comment 10

[Dave Garrett]

Also verified fixed for EULA via this URL:
https://addons.allizom.org/en-US/firefox/addon/delicious-bookmarks/eula/52958

Comment 11

[Dave Garrett]

I'm just verifying the fix for a bug affecting me. If the QA team needs to do more testing beyond the bug as filed please do so. If there's a lot more to test here a new bug to cover it might make sense, as this one specifically is complete. This general type of bug is a repeating problem that has popped up many times in the past again and again. I wouldn't be surprised if there are other fields where this is also the case again.