Reconcile group minWidth/Height

RESOLVED FIXED in Future

Status

defect
P4
normal
RESOLVED FIXED
9 years ago
3 years ago

People

(Reporter: iangilman, Assigned: mitcho)

Tracking

unspecified
Future
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [qa-])

In GroupItem.setBounds, we force the minimum width of 110 and minimum height of 125, yet in GroupItem.setResizable, we're using 90 and 90. We should up the numbers in setResizable, and use them from setBounds (this.resizeOptions.minWidth, etc). (This came up during bug 587248, where the discrepancy cost Ehsan a couple hours of head banging.)
Note that these new numbers (110, 125) were added in this patch:

http://hg.mozilla.org/mozilla-central/diff/713c68fc1827/browser/base/content/tabcandy/app/groups.js

... which is a month more recent than I can find the earliest mention of the 90, 90 numbers.
Assignee: ian → mitcho
Depends on: 622631
bugspam (moving b9 to b10)
Blocks: 608028
bugspam (removing b9)
No longer blocks: 598154
Punting, though bug 622631 should fix this anyway
No longer blocks: 608028
Target Milestone: --- → Future
Bug 622631 has now landed
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [qa-]
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.