609446 - Remove GroupItem's xDensity and yDensity properties

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P4)

Description

[Ian Gilman [:iangilman]]

They landed in:

http://hg.mozilla.org/mozilla-central/diff/254300336b6b/browser/base/content/tabcandy/app/groups.js

... back in July, and I have no idea what they're for. Ehsan has pointed out they're entirely write-only, so we should be able to pull them right out.

Comment 1

[(no longer active)]

Of course this has to be double-checked before being removed.  I basically did a grep in browser/base/content/tabview and we only write to it there.  I didn't investigate it further.

Comment 2

[Michael Yoshitaka Erlewine [:mitcho]]

xDensity and yDensity are indeed currently not being used. I wanted some notion like this, a while ago, in preparation for rewriting the squishing code. The idea is that I could look at xDensity and yDensity to see whether it would be more or less "costly" to squish a group a certain way.

We can kill this for now, though, and if the rewrite of squish needs to use this, we can reintroduce it then.

Comment 3

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch

Comment 4

[Ian Gilman [:iangilman]]

Comment on attachment 488784 [details] [diff] [review]
Patch

Looking good.

Comment 5

[Ian Gilman [:iangilman]]

Does it need a try run?

Comment 6

[Michael Yoshitaka Erlewine [:mitcho]]

Sent to try: 1524975ec79c

Can we get approval for this?

Comment 7

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Cleaned up patch (exactly what was pushed to try just now)

Comment 8

[Michael Yoshitaka Erlewine [:mitcho]]

(In reply to comment #7)
> Created attachment 492219 [details] [diff] [review]
> Cleaned up patch (exactly what was pushed to try just now)

Sorry, just to clarify: this is just to counter the rot.

Comment 9

[Michael Yoshitaka Erlewine [:mitcho]]

Attachment: Patch for checkin

First try run had a lot of intermittent orange. Tried another run today which came out clean. Ready to checkin.

Comment 10

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/1734c74f4139

Comment 11

[Tracy Walker [:tracy]]

verified per try runs