If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Remove GroupItem's xDensity and yDensity properties

VERIFIED FIXED in Firefox 4.0b8

Status

Firefox Graveyard
Panorama
P4
normal
VERIFIED FIXED
7 years ago
2 years ago

People

(Reporter: iangilman, Assigned: mitcho)

Tracking

unspecified
Firefox 4.0b8

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

7 years ago
They landed in:

http://hg.mozilla.org/mozilla-central/diff/254300336b6b/browser/base/content/tabcandy/app/groups.js

... back in July, and I have no idea what they're for. Ehsan has pointed out they're entirely write-only, so we should be able to pull them right out.
Of course this has to be double-checked before being removed.  I basically did a grep in browser/base/content/tabview and we only write to it there.  I didn't investigate it further.
(Assignee)

Comment 2

7 years ago
xDensity and yDensity are indeed currently not being used. I wanted some notion like this, a while ago, in preparation for rewriting the squishing code. The idea is that I could look at xDensity and yDensity to see whether it would be more or less "costly" to squish a group a certain way.

We can kill this for now, though, and if the rewrite of squish needs to use this, we can reintroduce it then.
(Assignee)

Comment 3

7 years ago
Created attachment 488784 [details] [diff] [review]
Patch
Assignee: nobody → mitcho
Status: NEW → ASSIGNED
Attachment #488784 - Flags: feedback?(ian)
(Reporter)

Comment 4

7 years ago
Comment on attachment 488784 [details] [diff] [review]
Patch

Looking good.
Attachment #488784 - Flags: feedback?(ian) → feedback+
(Assignee)

Updated

7 years ago
Attachment #488784 - Flags: review?(dolske)
Attachment #488784 - Flags: review?(dolske) → review+
(Assignee)

Updated

7 years ago
Attachment #488784 - Flags: approval2.0?
(Reporter)

Comment 5

7 years ago
Does it need a try run?
(Assignee)

Comment 6

7 years ago
Sent to try: 1524975ec79c

Can we get approval for this?
(Assignee)

Comment 7

7 years ago
Created attachment 492219 [details] [diff] [review]
Cleaned up patch (exactly what was pushed to try just now)
Attachment #488784 - Attachment is obsolete: true
Attachment #488784 - Flags: approval2.0?
(Assignee)

Comment 8

7 years ago
(In reply to comment #7)
> Created attachment 492219 [details] [diff] [review]
> Cleaned up patch (exactly what was pushed to try just now)

Sorry, just to clarify: this is just to counter the rot.
(Assignee)

Updated

7 years ago
Attachment #492219 - Flags: approval2.0?
Attachment #492219 - Flags: approval2.0? → approval2.0+
(Assignee)

Comment 9

7 years ago
Created attachment 493332 [details] [diff] [review]
Patch for checkin

First try run had a lot of intermittent orange. Tried another run today which came out clean. Ready to checkin.
Attachment #492219 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/1734c74f4139
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b8
verified per try runs
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.