60945 - subscribe dialog doesn't remember the size that the User resizes it to

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, enhancement, P3)

Description

[Paul Gregg]

From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 5.5; Windows NT 4.0)  [only since Moz 
wouldn't work]
BuildID:    2000112004

As mentioned in <A HREF="show_bug.cgi?id=57663">Bug 57663</A>, Seth requested 
that I open this bug...

When the User opens the subscribe dialog, resizes the dialog larger to make it 
easier to use, then closes it (maybe to look at newsgroups they have subscribed 
too [I guess IMAP as well]), then reopens it again, the dialog doesn't remember 
the size the User left it in.

It would be nice if the Subscribe dialog did remeber the Users resizing.

Obviously this isn't urgent, but aids the overall usability of Mozilla, in this 
case, the Subscribe dialog

Not sure where the dimensions of the dialog should be stored, is there a 
precedence for this?? Prefs.js could be one, but seems overkill, since it 
wouldn't matter if prefs were moved to another computer, and these dimensions 
were lost.

Reproducible: Always
Steps to Reproduce:
1. Open Mozilla
2. Open Mail&News
3. Right click on a pre-configured newsserver [maybe IMAP as well] and
    select "Subscribe" (or through the File menu)
4. Subscribe dialog should pop-up
5. Resize the dimensions of the dialog to make it larger (for easier viewing
    of long newsgroup names)
6. Close the larger Subscribe dialog
7. Repeat steps to open the Subscribe dialog again


Actual Results:  Subscribe dialog returns to its original size (default/hard-
coded?).

Expected Results:  Subscribe dialog returns to the size that the User resized 
it to, the last time the User had the dialog open.

Comment 1

[(not reading, please use [e-mail] instead)]

accepting.  this is a valid bug.

Comment 2

[(not reading, please use [e-mail] instead)]

fixing typo.

adding esther back to the cc list.

Comment 3

[Paul Gregg]

Sorry about that, should of checked, would of stuffed up queries...

Seth, do you need any help on this??
I haven't contributed yet, but with a few pointers on what to do and where to
start, I maybe able to reduce some load, but then again, the overhead of telling
me what to do maybe too much

I'm strong in C++ (but not in the Moz style), and Web development (HTML/JS/ASP/PHP)
I have been following Mozilla a fair bit, and have complied the source a few
times.  I've had some of my staff hacking the Editor too...

Comment 4

[Paul Gregg]

Sorry if I'm spamming but..
The Page Info dialog in the browser remembers the resize state on reuse, and
even after application restart.  This looks like a precedence we could follow,
maybe it is done in a 'correct' way (non-hack that is)

Paul

Comment 5

[(not reading, please use [e-mail] instead)]

paul, I could always use help.

all we need to do is use the persist attribute in subscribe.xul.

we should be persisting the window size and position, and the column widths.

take a look at messenger.xul and threadPane.xul, look for the word "persist".

if you come up with a fix, attach the patch to this bug.  let me know if you
need more help, or if you want other bugs to work on.  (I've got plenty.)

Comment 6

[(not reading, please use [e-mail] instead)]

fix in hand, I'll attach the patch.

Comment 7

[(not reading, please use [e-mail] instead)]

Attachment: fix

Comment 8

[(not reading, please use [e-mail] instead)]

seeking sr= for this trivial fix.  mscott?  bienvenu?

Comment 9

[David :Bienvenu]

sr=bienvenu

Comment 10

[(not reading, please use [e-mail] instead)]

fixed.

Comment 11

[[e-mail] (gone - use [e-mail] instead)]

Okay, this is verified FIXED on today's mac build 12-5-00, and Windows NT build
2000120504.  I need linux to verify, marking VERIFYME in keyword field.

Comment 12

[[e-mail] (gone - use [e-mail] instead)]

Verifying FIXED on Linux (RedHat 7) 2000120508.