609674 - Error: this._mostRecentActivityForFolder[aFolder.URI] is undefined Source File: file:///Applications/Lanikai.app/Contents/MacOS/modules/activity/pop3Download.js Line: 127

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect)

Description

[juan becerra [:juanb]]

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.13pre) Gecko/20101104 Lightning/1.0b2 Lanikai/3.1.7pre (imap account)

This morning I noticed I stopped getting mail, at around 8:30am. The application prompts me for my master password, as usual, and it seems to check for mail, but nothing's there. I checked my mail in zimbra, and new mail is there.

The error console has lots of messages like:

Error: Assert failed: Timezone not available: (GMT-08.00) Pacific Time (US & Canada)
2: [file:///Users/jbecerra/Library/Thunderbird/Profiles/7uc3bj3k.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/modules/calStorageHelpers.jsm:236] newDateTime
3: [file:///Users/jbecerra/Library/Thunderbird/Profiles/7uc3bj3k.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/modules/calUtils.jsm -> file:///Users/jbecerra/Library/Thunderbird/Profiles/7uc3bj3k.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calStorageCalendar.js:1331] cSC_getEventFromRow
4: [file:///Users/jbecerra/Library/Thunderbird/Profiles/7uc3bj3k.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/modules/calUtils.jsm -> file:///Users/jbecerra/Library/Thunderbird/Profiles/7uc3bj3k.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calStorageCalendar.js:759] cSC_getItems_
5: [file:///Users/jbecerra/Library/Thunderbird/Profiles/7uc3bj3k.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/modules/calUtils.jsm -> file:///Users/jbecerra/Library/Thunderbird/Profiles/7uc3bj3k.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calStorageCalendar.js:605] anonymous

Source File: file:///Users/jbecerra/Library/Thunderbird/Profiles/7uc3bj3k.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/modules/calUtils.jsm -> file:///Users/jbecerra/Library/Thunderbird/Profiles/7uc3bj3k.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/calendar-js/calUtils.js
Line: 975

Comment 1

[rsx11m]

These errors point to Lightning, so let's start there...

Comment 2

[Stefan Sitter [:ssitter]]

Might be the same as Bug 407801.

Comment 3

[juan becerra [:juanb]]

I've since quit the application, checked my email using the web interface, re-opened the application, and I'm now getting my mail. Errors persist, though.

Comment 4

[juan becerra [:juanb]]

Lanikai stopped retrieving mail again today. I've disabled Lightning, and today I get this. I've checked my settings, and I actually have it set to use pop.

Error: this._mostRecentActivityForFolder[aFolder.URI] is undefined
Source File: file:///Applications/Lanikai.app/Contents/MacOS/modules/activity/pop3Download.js
Line: 127

Comment 5

[juan becerra [:juanb]]

One more clue. After a few more restarts, and one installation on top of the existing one, it worked again (not sure for how long) and this is showing in the error console:

Error: [Exception... "'Component is not available' when calling method: [nsIActivityManager::removeActivity]"  nsresult: "0x80040111 (NS_ERROR_NOT_AVAILABLE)"  location: "JS frame :: file:///Applications/Lanikai.app/Contents/MacOS/modules/activity/pop3Download.js :: anonymous :: line 158"  data: no]
Source File: file:///Applications/Lanikai.app/Contents/MacOS/modules/activity/pop3Download.js
Line: 158

Comment 6

[juan becerra [:juanb]]

Placing back in Thuderbird since I've disabled Lightning and this is still happening.

Comment 7

[Mark Banner (:standard8)]

I believe the error itself is non-fatal, i.e. it will not stop anything from working.

However, it may be indicative of some of error in pop3 activity.

Can you try getting a pop3 log as detailed here:

https://wiki.mozilla.org/MailNews:Logging

you'll need NSPR_LOG_MODULES set to pop3:5,timestamp

Comment 8

[juan becerra [:juanb]]

Attachment: Log during opening app, checking for mail, entering master password, let it check for new mail...

Comment 9

[David :Bienvenu]

Looks like an error trying to get the password. You might be getting an error trying to retrieve the password from the password manager.

Comment 10

[juan becerra [:juanb]]

I re-installed today's nightly, and it worked today. Since then I have disabled the master password. I'll keep an eye on it.

Comment 11

[juan becerra [:juanb]]

Well, I keep not getting mail: 

2010-11-09 00:02:35.370973 UTC - -1597799168[270b8f0]: Setting server busy in nsPop3Protocol::LoadUrl
2010-11-09 00:03:05.840076 UTC - -1597799168[270b8f0]: Entering NET_ProcessPop3 0
2010-11-09 00:03:05.865276 UTC - -1597799168[270b8f0]: POP3: Entering state: 24
2010-11-09 00:03:05.865310 UTC - -1597799168[270b8f0]: POP3: Entering state: 25
2010-11-09 00:03:05.865322 UTC - -1597799168[270b8f0]: Clearing server busy in POP3_FREE
2010-11-09 00:03:05.865333 UTC - -1597799168[270b8f0]: Clearing running protocol in POP3_FREE
2010-11-09 00:03:05.865344 UTC - -1597799168[270b8f0]: Clearing server busy in OnStopRequest
2010-11-09 00:03:05.865365 UTC - -1597799168[270b8f0]: Calling ReleaseFolderLock from AbortMailDelivery
2010-11-09 00:03:05.865379 UTC - -1597799168[270b8f0]: ReleaseFolderLock haveSemaphore = FALSE
2010-11-09 00:03:05.870931 UTC - -1597799168[270b8f0]: Clearing running protocol in nsPop3Protocol::Abort
2010-11-09 00:03:05.873525 UTC - -1597799168[270b8f0]: Calling ReleaseFolderLock from ~nsPop3Sink
2010-11-09 00:03:05.873545 UTC - -1597799168[270b8f0]: ReleaseFolderLock haveSemaphore = FALSE
2010-11-09 00:04:18.539763 UTC - -1597799168[270b8f0]: Setting server busy in nsPop3Protocol::LoadUrl
2010-11-09 00:06:06.551797 UTC - -1597799168[270b8f0]: Entering NET_ProcessPop3 0
2010-11-09 00:06:06.551832 UTC - -1597799168[270b8f0]: POP3: Entering state: 24
2010-11-09 00:06:06.551842 UTC - -1597799168[270b8f0]: POP3: Entering state: 25
2010-11-09 00:06:06.551853 UTC - -1597799168[270b8f0]: Clearing server busy in POP3_FREE
2010-11-09 00:06:06.551863 UTC - -1597799168[270b8f0]: Clearing running protocol in POP3_FREE
2010-11-09 00:06:06.551874 UTC - -1597799168[270b8f0]: Clearing server busy in OnStopRequest
2010-11-09 00:06:06.551884 UTC - -1597799168[270b8f0]: Calling ReleaseFolderLock from AbortMailDelivery
2010-11-09 00:06:06.551895 UTC - -1597799168[270b8f0]: ReleaseFolderLock haveSemaphore = FALSE
2010-11-09 00:06:06.552194 UTC - -1597799168[270b8f0]: Clearing running protocol in nsPop3Protocol::Abort

Comment 12

[juan becerra [:juanb]]

Could this be a networking or mail server issue? I seem to be able to check mail after launching the application for the first time every day, but after that I don't get new mail. I have had to resort to the web interface to check my mail, which I don't really enjoy.

Comment 13

[juan becerra [:juanb]]

While tesing a different bug I installed Tb 2.0.0.24, and Tb 3.1.5 (20101013) and I don't see the error message when I launch app or when I check for mail using those versions.

Comment 14

[juan becerra [:juanb]]

Meh, this came back.

Comment 15

[David :Bienvenu]

Do you have Thunderbird set to remember your password, or does it prompt you when you startup, and then not after?

Comment 16

[Wayne Mery (:wsmwk)]

juan ??

(In reply to David :Bienvenu from comment #15)
> Do you have Thunderbird set to remember your password, or does it prompt you
> when you startup, and then not after?

Comment 17

[juan becerra [:juanb]]

I haven't used Thunderbird in quite a while and I have since removed the profile where I was experiencing this problem. At the time, however, I did have Thunderbird set to remember my password.

Comment 18

[:aceman]

Attachment: 609674.patch

I could reproduce something similar:
- Download msgs from pop3
- Clear list of activities from Activity manager
- Download from the same server again (probably no messages).

I get the failure of removeActivity. So this patch fixes that. Either we check it at the caller (as in the patch), or we make removeActivity() silently eat requests for nonexisting activities and return success.

The isGroup addition fixes another warning I saw in this test that we referenced next.isGroup and that property was not existing. It is probably harmless but I don't like such warnings about things we know about (the base binding doesn't have the property as it would be false) as it then makes it harder to see real errors. I could also fix it by changing next.isGroup to ("isGroup" in next && next.isGroup). So your call :)

Comment 19

[Magnus Melin [:mkmelin]]

Comment on attachment 8426569 [details] [diff] [review]
609674.patch

Review of attachment 8426569 [details] [diff] [review]:
-----------------------------------------------------------------

I suppose this is the easiest fix yes. r=mkmelin

Comment 20

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/comm-central/rev/536222e65010