609856 - Implement Node.parentElement

Status: RESOLVED DUPLICATE of bug 685798

(Core :: DOM: Core & HTML, defect)

Description

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Web DOM Core formally defines it, and all our colleagues already support it.

Comment 1

[Alex Vincent [:WeirdAl]]

Pardon my asking a peanut gallery question, but why is parentElement a good idea?  As far as I can tell, it's just the parent node (unless the parent node isn't an element, in which case the parentElement property is null).  Sounds more like an optimization (skipping the nodeType check on the parent node) than an actual improvement.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

Still needs tests.

Comment 4

[Boris Zbarsky [:bzbarsky]]

If we expect people to use this extensively (do we?) we should quickstub and fast-path it....

Comment 5

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Comment on attachment 511947 [details] [diff] [review]
Patch v1

r=me, though don't land this unless you also have tests checking things like nodes inside documents and nodes inside docfragments. And by nodes I mean both textnodes and elements.

But yeah, fast-pathing also seems like something we should do.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Dupping forward to bug with better patch.

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Great, thanks.