609903 - Closing a tab opened in background produces lock/unlock toolbar inbalance

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Ioana Chiorean]

Build Identifier: Mozilla/5.0 (Android; Linux armv7l; en-US; rv:2.0b8pre)
Gecko/20101105 Firefox/4.0b8pre Fennec/4.0b3pre 

Device Motorola Droid 2

Steps to Reproduce:
1. Open Fennec 
2. Go to http://people.mozilla.com/~nhirata/html_tp/listlinks.html
3. Long tab on https://wiki.mozilla.org/QA/Fennec/Milestones/2.0#P1_.28must_have.27s.29
4. Choose open in a new tab
5. Slide to right to get the tab panel
6. Close one of the tabs

Actual Results:  
- the URL enlarge itself

Expected Results:  
- the behavior should not produce changes of the url bar

Note:
-see video from :
http://www.youtube.com/watch?v=1b8tiX2u8mc

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Step #6 should say "Close the background tab"

The background tab must be closed before it finishes loading to see the bug.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Regression from bug 604917

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

We should only unlock the toolbar if the tab is the selected tab. Background tabs do not lock the toolbar when loading

Comment 4

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Comment on attachment 489501 [details] [diff] [review]
patch

(In reply to comment #3)
> Created attachment 489501 [details] [diff] [review]
> patch
> 
> We should only unlock the toolbar if the tab is the selected tab. Background
> tabs do not lock the toolbar when loading

I know you like our lock/unlock mechanism so much...

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

note, this change does not regress bug 604917

http://hg.mozilla.org/mobile-browser/rev/501a13e00154

Comment 6

[Kevin Brosnan [Ex-Mozilla]]

Verified Mozilla/5.0 (Android; Linux armv7l; rv:2.0b13pre) Gecko/20110315 Firefox/4.0b13pre Fennec/4.0b6pre ID:20110315035936