610212 - canvas.width and canvas.height should be reflected as unsigned int

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mounir Lamouri (:mounir)]

Those attributes are declared as long instead of unsigned long in the IDL and the reflection isn't correct.

Comment 1

[Mounir Lamouri (:mounir)]

Attachment: Patch v1

Should we push that in Gecko 2.0 even if it changes the IDL?

Comment 2

[Benjamin Smedberg]

Unless there's something not listed in the bug, I don't think this is worth breaking API freeze for. I know that several binary extensions use nsIDOMHTMLCanvasElement.

Comment 3

[Mounir Lamouri (:mounir)]

(In reply to comment #2)
> Unless there's something not listed in the bug, I don't think this is worth
> breaking API freeze for. I know that several binary extensions use
> nsIDOMHTMLCanvasElement.

We might be one of the last "modern browsers" to have canvas.width and canvas.height to not default correctly and we are failing some tests in HTML5 Test Suite because of that. But I agree I do not see a reason big enough to break compatibility.
In another hand, I really don't see how moving from long to unsigned long might break something (it would be insane to set a negative value to a width or a height).

Comment 4

[Benjamin Smedberg]

I figured we'd never actually get negative values, so that's not my concern. We're already past API-freeze for Firefox 4, which means that IDL changes are not allowed except by very special exception.

Comment 5

[Johnny Stenback (:jst)]

Comment on attachment 488745 [details] [diff] [review]
Patch v1

r=jst, but yeah, let's land this after branching.

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Surely you need changes to test_canvas.html too?

Comment 8

[(no longer active)]

Is this something to consider for Firefox 5?

Comment 9

[Boris Zbarsky [:bzbarsky]]

Imo, yes.

Comment 10

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/873390caf174

Comment 11

[Eric Shepherd [:sheppy]]

Updated documentation:

https://developer.mozilla.org/en/HTML/Element/canvas

And mentioned on Firefox 5 for developers.