Closed
Bug 610214
Opened 14 years ago
Closed 14 years ago
Create reftest.js to add methods to check HTML attribute reflection
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla2.0b8
People
(Reporter: mounir, Assigned: mounir)
References
Details
Attachments
(1 file)
|
9.71 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
First method has been introduced with bug 601061. This method has to be moved to reflect.js so it can be used in bug 610212.
Attachment #488744 -
Flags: review?(Olli.Pettay)
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → mounir.lamouri
Status: NEW → ASSIGNED
|
||
Comment 1•14 years ago
|
||
Comment on attachment 488744 [details] [diff] [review] Patch v1 >-function reflectUnsignedInt(aElement, aAttr, aNonNull, aDefault) >+/** >+ * Checks that a given attribute name for a given element name is correctly >+ * reflected as an unsigned int. >+ */ >+function reflectUnsignedInt(aElementName, aAttr, aNonNull, aDefault) I think it would make more sense to keep first parameter to be Element, not just Element name. That way caller can pass also elements which have been initialized somehow. With that change, r+.
Attachment #488744 -
Flags: review?(Olli.Pettay) → review+
|
|
Assignee | |
Comment 2•14 years ago
|
||
Pushed: http://hg.mozilla.org/mozilla-central/rev/74efbd8a5184
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in
before you can comment on or make changes to this bug.
Description
•