Last Comment Bug 610340 - Truncate form validation message only if they are content specified (Port Bug 606817)
: Truncate form validation message only if they are content specified (Port Bug...
Status: RESOLVED FIXED
:
Product: SeaMonkey
Classification: Client Software
Component: General (show other bugs)
: Trunk
: All All
: -- normal (vote)
: seamonkey2.1b2
Assigned To: Philip Chee
:
Mentors:
Depends on: 599745 606817
Blocks:
  Show dependency treegraph
 
Reported: 2010-11-08 02:26 PST by Philip Chee
Modified: 2012-08-01 20:37 PDT (History)
2 users (show)
bugzillamozillaorg_serge_20140323: in‑testsuite+
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Patch v1.0 fix code plus test. (10.66 KB, patch)
2010-11-08 07:37 PST, Philip Chee
neil: review+
Details | Diff | Review

Description Philip Chee 2010-11-08 02:26:40 PST

    
Comment 1 Mounir Lamouri (:mounir) 2010-11-08 02:46:06 PST
You only need to remove the cut to 256 characters in your browser.js. The truncature is now done by the content so you will received an already truncated string if it needs to be truncated.
Comment 2 Philip Chee 2010-11-08 04:32:56 PST
We also need to port the changes in the tests. But thanks for the information.
Comment 3 Philip Chee 2010-11-08 04:35:50 PST
ToDo:
1. Port UI and test changes from Bug 606817.
2. Port test changes from:
2.1 [Bug 600155] Let the authors override validation message with x-mozerrormessage attribute.
2.2 http://hg.mozilla.org/mozilla-central/rev/b343269c3aa4
    Merging to tip. a=blocking-b7
Comment 4 Philip Chee 2010-11-08 07:37:53 PST
Created attachment 488870 [details] [diff] [review]
Patch v1.0 fix code plus test.

Ports Bug 606817, plus roll-up fix for all the patches from Firefox for browser_bug561636.js
Comment 5 Philip Chee 2010-11-08 07:39:24 PST
Note: passes all tests in browser_bug561636.js using:
$ TEST_PATH=suite/browser/test/browser_bug561636.js make -C ../objdir-sm/ mochitest-browser-chrome
Comment 6 Philip Chee 2010-11-08 07:50:39 PST
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/7c770ed05601

Note You need to log in before you can comment on or make changes to this bug.