Truncate form validation message only if they are content specified (Port Bug 606817)

RESOLVED FIXED in seamonkey2.1b2

Status

SeaMonkey
General
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: Philip Chee, Assigned: Philip Chee)

Tracking

Trunk
seamonkey2.1b2
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

7 years ago
Blocks: 467530
(Assignee)

Updated

7 years ago
Depends on: 599745
You only need to remove the cut to 256 characters in your browser.js. The truncature is now done by the content so you will received an already truncated string if it needs to be truncated.
(Assignee)

Comment 2

7 years ago
We also need to port the changes in the tests. But thanks for the information.
(Assignee)

Comment 3

7 years ago
ToDo:
1. Port UI and test changes from Bug 606817.
2. Port test changes from:
2.1 [Bug 600155] Let the authors override validation message with x-mozerrormessage attribute.
2.2 http://hg.mozilla.org/mozilla-central/rev/b343269c3aa4
    Merging to tip. a=blocking-b7
(Assignee)

Comment 4

7 years ago
Created attachment 488870 [details] [diff] [review]
Patch v1.0 fix code plus test.

Ports Bug 606817, plus roll-up fix for all the patches from Firefox for browser_bug561636.js
Attachment #488870 - Flags: review?(neil)
(Assignee)

Comment 5

7 years ago
Note: passes all tests in browser_bug561636.js using:
$ TEST_PATH=suite/browser/test/browser_bug561636.js make -C ../objdir-sm/ mochitest-browser-chrome

Updated

7 years ago
Attachment #488870 - Flags: review?(neil) → review+
(Assignee)

Comment 6

7 years ago
Pushed to comm-central
http://hg.mozilla.org/comm-central/rev/7c770ed05601
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
No longer blocks: 467530
Flags: in-testsuite+
Target Milestone: --- → seamonkey2.1b2
(Assignee)

Updated

5 years ago
Depends on: 779720
(Assignee)

Updated

5 years ago
No longer depends on: 779720
You need to log in before you can comment on or make changes to this bug.