Closed Bug 779720 Opened 9 years ago Closed 9 years ago

Fix nits noticed in patch for Bug 599745 (invalidformsubmit)

Categories

(SeaMonkey :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.14

People

(Reporter: philip.chee, Assigned: ananuti)

References

Details

(Whiteboard: [good first bug][mentor=IanN][lang=js][level=apprentice])

Attachments

(1 file, 1 obsolete file)

From Bug 599745 Comment 28:
>>+    function eventHandler() {
>>+      gFormSubmitObserver.panel.hidePopup();
>>+    };
> Bah, I totally overlooked the superfluous semicolon :-(

Also:

http://hg.mozilla.org/comm-central/diff/3c80a5c9aec3/suite/browser/navigator.js#l1.120
>  Services.obs.removeObserver(observer, "invalidformsubmit", false);
removeObserver() takes only two parameters.
No longer blocks: 599628, 601091, 610340
No longer depends on: 561636, 630140
Attached patch patch (obsolete) — Splinter Review
Assignee: nobody → ananuti
Status: NEW → ASSIGNED
Attachment #648235 - Flags: review?(iann_bugzilla)
I believe there is another superfluous semicolon - http://mxr.mozilla.org/comm-central/source/suite/browser/navigator.js#163
Attached patch patch1Splinter Review
rm another superfluous semicolon.
Attachment #648235 - Attachment is obsolete: true
Attachment #648235 - Flags: review?(iann_bugzilla)
Attachment #648946 - Flags: review?(iann_bugzilla)
Comment on attachment 648946 [details] [diff] [review]
patch1

Looks good, thanks r=me
Attachment #648946 - Flags: review?(iann_bugzilla) → review+
Keywords: checkin-needed
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/feca84583e23
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.14
You need to log in before you can comment on or make changes to this bug.