Fix nits noticed in patch for Bug 599745 (invalidformsubmit)

RESOLVED FIXED in seamonkey2.14

Status

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: philip.chee, Assigned: ananuti)

Tracking

Trunk
seamonkey2.14
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=IanN][lang=js][level=apprentice])

Attachments

(1 attachment, 1 obsolete attachment)

2.77 KB, patch
iann_bugzilla
: review+
Details | Diff | Splinter Review
Reporter

Description

7 years ago
From Bug 599745 Comment 28:
>>+    function eventHandler() {
>>+      gFormSubmitObserver.panel.hidePopup();
>>+    };
> Bah, I totally overlooked the superfluous semicolon :-(

Also:

http://hg.mozilla.org/comm-central/diff/3c80a5c9aec3/suite/browser/navigator.js#l1.120
>  Services.obs.removeObserver(observer, "invalidformsubmit", false);
removeObserver() takes only two parameters.
Reporter

Updated

7 years ago
No longer blocks: 599628, 601091, 610340
No longer depends on: 561636, 630140
Assignee

Comment 1

7 years ago
Posted patch patch (obsolete) — Splinter Review
Assignee: nobody → ananuti
Status: NEW → ASSIGNED
Attachment #648235 - Flags: review?(iann_bugzilla)

Comment 2

7 years ago
I believe there is another superfluous semicolon - http://mxr.mozilla.org/comm-central/source/suite/browser/navigator.js#163
Assignee

Comment 3

7 years ago
Posted patch patch1Splinter Review
rm another superfluous semicolon.
Attachment #648235 - Attachment is obsolete: true
Attachment #648235 - Flags: review?(iann_bugzilla)
Attachment #648946 - Flags: review?(iann_bugzilla)

Comment 4

7 years ago
Comment on attachment 648946 [details] [diff] [review]
patch1

Looks good, thanks r=me
Attachment #648946 - Flags: review?(iann_bugzilla) → review+
Assignee

Updated

7 years ago
Keywords: checkin-needed
Reporter

Comment 5

7 years ago
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/feca84583e23
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.14
You need to log in before you can comment on or make changes to this bug.