Closed
Bug 779720
Opened 12 years ago
Closed 12 years ago
Fix nits noticed in patch for Bug 599745 (invalidformsubmit)
Categories
(SeaMonkey :: General, defect)
SeaMonkey
General
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.14
People
(Reporter: philip.chee, Assigned: ananuti)
References
Details
(Whiteboard: [good first bug][mentor=IanN][lang=js][level=apprentice])
Attachments
(1 file, 1 obsolete file)
|
2.77 KB,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
From Bug 599745 Comment 28:
>>+ function eventHandler() {
>>+ gFormSubmitObserver.panel.hidePopup();
>>+ };
> Bah, I totally overlooked the superfluous semicolon :-(
Also:
http://hg.mozilla.org/comm-central/diff/3c80a5c9aec3/suite/browser/navigator.js#l1.120
> Services.obs.removeObserver(observer, "invalidformsubmit", false);
removeObserver() takes only two parameters.
|
Reporter | |
Updated•12 years ago
|
|
|
Assignee | |
Comment 1•12 years ago
|
||
I believe there is another superfluous semicolon - http://mxr.mozilla.org/comm-central/source/suite/browser/navigator.js#163
|
|
Assignee | |
Comment 3•12 years ago
|
||
rm another superfluous semicolon.
Attachment #648235 -
Attachment is obsolete: true
Attachment #648235 -
Flags: review?(iann_bugzilla)
Attachment #648946 -
Flags: review?(iann_bugzilla)
Comment on attachment 648946 [details] [diff] [review]
patch1
Looks good, thanks r=me
Attachment #648946 -
Flags: review?(iann_bugzilla) → review+
|
|
Assignee | |
Updated•12 years ago
|
Keywords: checkin-needed
|
|
Reporter | |
Comment 5•12 years ago
|
||
Pushed to comm-central:
http://hg.mozilla.org/comm-central/rev/feca84583e23
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.14
|
||
Updated•12 years ago
|
Keywords: checkin-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•