610362 - Map HTML5:aside landmark element to role="note"

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Marco Zehe (:MarcoZ)]

This was an oversight from bug 593368.

Comment 1

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: patch

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: patch 2 (to spec)

Comment 3

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: patch 2.1 (more spec conformance)

Comment 4

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 489168 [details] [diff] [review]
patch 2.1 (more spec conformance)

>+++ b/accessible/src/msaa/nsRoleMap.h
> 
>+  // nsIAccessibleRole::ROLE_NOTE
>+  { USE_ROLE_SECTION, IA2_ROLE_NOTE },
>+

This is bogus (thnx surkov)

Comment 5

[David Bolter [:davidb] (NeedInfo me for attention)]

Attachment: patch 2.2 (fixed msaa role)

This matches what we do for ROLE_SECTION in MSAA (i.e. use role string).

Comment 6

[Marco Zehe (:MarcoZ)]

Comment on attachment 489175 [details] [diff] [review]
patch 2.2 (fixed msaa role)

NIT: Please update the UUID for nsIAccessibleRole.idl.

r=me with that. :)

Comment 7

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 489175 [details] [diff] [review]
patch 2.2 (fixed msaa role)

Marco, I'd need special approval for that since we are uuid frozen. I'll do this if necessary but...

Neil, is it safe to leave the uuid as is, since I'm only adding a role to the end?

Comment 8

[[e-mail]]

Comment on attachment 489175 [details] [diff] [review]
patch 2.2 (fixed msaa role)

Sure, constant additions don't need uuid changes. (ROLE_LAST_ENTRY is really an internal constant but we don't have any way of expressing that.)

Comment 9

[David Bolter [:davidb] (NeedInfo me for attention)]

Comment on attachment 489175 [details] [diff] [review]
patch 2.2 (fixed msaa role)

Approving (html5 access)

Comment 10

[David Bolter [:davidb] (NeedInfo me for attention)]

http://hg.mozilla.org/mozilla-central/rev/92b95ca3183b

Thanks.

Comment 11

[David Bolter [:davidb] (NeedInfo me for attention)]

I've emailed the ia2 for doc change follow up.