Closed Bug 610362 Opened 9 years ago Closed 9 years ago

Map HTML5:aside landmark element to role="note"

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: MarcoZ, Assigned: davidb)

References

(Blocks 1 open bug)

Details

(Whiteboard: [needs doc update AT-APIs/IA2/Roles])

Attachments

(1 file, 3 obsolete files)

This was an oversight from bug 593368.
Assignee: nobody → bolterbugz
Status: NEW → ASSIGNED
Summary: Map HTML5:aside landmark element to role="complelentary" → Map HTML5:aside landmark element to role="complementary"
Attached patch patch (obsolete) — Splinter Review
Attachment #488947 - Flags: review?(marco.zehe)
Attachment #488947 - Flags: review?(marco.zehe) → review+
Summary: Map HTML5:aside landmark element to role="complementary" → Map HTML5:aside landmark element to role="note"
Attached patch patch 2 (to spec) (obsolete) — Splinter Review
Attachment #488947 - Attachment is obsolete: true
Attachment #489147 - Flags: review?(marco.zehe)
Attachment #489147 - Flags: review?(marco.zehe) → review+
Attachment #489147 - Attachment is obsolete: true
Attachment #489168 - Flags: review?(marco.zehe)
Whiteboard: [needs doc update AT-APIs/IA2/Roles]
Comment on attachment 489168 [details] [diff] [review]
patch 2.1 (more spec conformance)

>+++ b/accessible/src/msaa/nsRoleMap.h
> 
>+  // nsIAccessibleRole::ROLE_NOTE
>+  { USE_ROLE_SECTION, IA2_ROLE_NOTE },
>+

This is bogus (thnx surkov)
Attachment #489168 - Flags: review?(marco.zehe)
This matches what we do for ROLE_SECTION in MSAA (i.e. use role string).
Attachment #489168 - Attachment is obsolete: true
Attachment #489175 - Flags: review?(marco.zehe)
Comment on attachment 489175 [details] [diff] [review]
patch 2.2 (fixed msaa role)

NIT: Please update the UUID for nsIAccessibleRole.idl.

r=me with that. :)
Attachment #489175 - Flags: review?(marco.zehe) → review+
Comment on attachment 489175 [details] [diff] [review]
patch 2.2 (fixed msaa role)

Marco, I'd need special approval for that since we are uuid frozen. I'll do this if necessary but...

Neil, is it safe to leave the uuid as is, since I'm only adding a role to the end?
Attachment #489175 - Flags: review?(neil)
Comment on attachment 489175 [details] [diff] [review]
patch 2.2 (fixed msaa role)

Sure, constant additions don't need uuid changes. (ROLE_LAST_ENTRY is really an internal constant but we don't have any way of expressing that.)
Attachment #489175 - Flags: review?(neil) → review+
Comment on attachment 489175 [details] [diff] [review]
patch 2.2 (fixed msaa role)

Approving (html5 access)
Attachment #489175 - Flags: approval2.0+
http://hg.mozilla.org/mozilla-central/rev/92b95ca3183b

Thanks.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
I've emailed the ia2 for doc change follow up.
Depends on: 765172
You need to log in before you can comment on or make changes to this bug.