Tab group resizer handle hover area is too small

VERIFIED FIXED

Status

Firefox Graveyard
Panorama
P2
trivial
VERIFIED FIXED
7 years ago
2 years ago

People

(Reporter: eevee, Assigned: eevee)

Tracking

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

7 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13pre) Gecko/20101101 Ubuntu/10.04 (lucid) Namoroka/3.6.13pre
Build Identifier: Mozilla/5.0 (X11; Linux x86_64; rv:2.0b8pre) Gecko/20101108 Firefox/4.0b8pre

There's a distinct gap between the resize handle in the lower left corner of a tab group and the edge of the actual container.  My window decorations have very thin borders, so I've gotten used to aiming at the exact edge of a window to resize, and Panorama's behavior is rather jarring.

I've attached a patch (I hope) that extends the grabbable area to the edge of the tab group container, including the border.

The same issue probably exists on Windows and OS X, but I don't have a build environment readily available for either.

Reproducible: Always

Steps to Reproduce:
1. Switch to Panorama.
2. Aim cursor at the lower-left corner of a tab group with deadly accuracy.
3.
Actual Results:  
Nothing.

Expected Results:  
I get a resize-se cursor and can resize the group.

Comment 2

7 years ago
Comment on attachment 489064 [details] [diff] [review]
patch

Tossing to Aza for feedback and UI
Attachment #489064 - Flags: feedback?(aza)

Comment 3

7 years ago
Yes, we should absolutely extend the grab target to the edge of the box.

Updated

7 years ago
Blocks: 598154
Priority: -- → P2
(In reply to comment #3)
> Yes, we should absolutely extend the grab target to the edge of the box.

Aza, please mark the patch with f+.

Comment 5

7 years ago
confirmed on linux x86 ubuntu 10.10

Updated

7 years ago
Attachment #489064 - Flags: feedback?(aza) → feedback+

Comment 6

7 years ago
bugspam (moving b9 to b10)
Blocks: 608028

Comment 7

7 years ago
bugspam (removing b9)
No longer blocks: 598154

Updated

7 years ago
Attachment #489064 - Flags: review?(ian)
Comment on attachment 489064 [details] [diff] [review]
patch

Looks good. It appears the same bug exists on Mac and Windows as well... please update them too.
Attachment #489064 - Flags: review?(ian) → review-
(Assignee)

Comment 9

7 years ago
Created attachment 505331 [details] [diff] [review]
patch for all platforms

I've only got Linux handy, but this *should* work for win/mac.
Attachment #489064 - Attachment is obsolete: true
Attachment #505331 - Flags: review?(ian)
Comment on attachment 505331 [details] [diff] [review]
patch for all platforms

Looks good to me. Please package for checkin as per:

https://wiki.mozilla.org/Firefox/Projects/TabCandy/Work#Landing

Thank you for doing this!
Attachment #505331 - Flags: review?(ian)
Attachment #505331 - Flags: review+
Attachment #505331 - Flags: approval2.0?
Assignee: nobody → eevee.mozilla
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Comment 11

7 years ago
bugspam. Moving b10 to b11
Blocks: 627096

Comment 12

7 years ago
bugspam. Removing b10
No longer blocks: 608028
(Assignee)

Comment 13

7 years ago
Created attachment 506069 [details] [diff] [review]
patch with hg metadata
(Assignee)

Comment 14

7 years ago
Like so?
Keywords: checkin-needed
You'll have to wait for approval first.
Keywords: checkin-needed
Attachment #506069 - Flags: approval2.0?
Attachment #505331 - Flags: approval2.0?
Has this been tested on all platforms now?
(In reply to comment #16)
> Has this been tested on all platforms now?

I can test.
Comment on attachment 506069 [details] [diff] [review]
patch with hg metadata

a+ assuming it's been tested on win/lin/mac.
Attachment #506069 - Flags: approval2.0? → approval2.0+
http://hg.mozilla.org/mozilla-central/rev/710deb1c54fb
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
verified with minefield build of 20110217
Status: RESOLVED → VERIFIED
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.