610557 - Tab group resizer handle hover area is too small

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect, P2)

Description

[Eevee (Evelyn Woods) [:eevee]]

User-Agent:       Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.13pre) Gecko/20101101 Ubuntu/10.04 (lucid) Namoroka/3.6.13pre
Build Identifier: Mozilla/5.0 (X11; Linux x86_64; rv:2.0b8pre) Gecko/20101108 Firefox/4.0b8pre

There's a distinct gap between the resize handle in the lower left corner of a tab group and the edge of the actual container.  My window decorations have very thin borders, so I've gotten used to aiming at the exact edge of a window to resize, and Panorama's behavior is rather jarring.

I've attached a patch (I hope) that extends the grabbable area to the edge of the tab group container, including the border.

The same issue probably exists on Windows and OS X, but I don't have a build environment readily available for either.

Reproducible: Always

Steps to Reproduce:
1. Switch to Panorama.
2. Aim cursor at the lower-left corner of a tab group with deadly accuracy.
3.
Actual Results:  
Nothing.

Expected Results:  
I get a resize-se cursor and can resize the group.

Comment 1

[Eevee (Evelyn Woods) [:eevee]]

Attachment: patch

Comment 2

[Kevin Hanes]

Comment on attachment 489064 [details] [diff] [review]
patch

Tossing to Aza for feedback and UI

Comment 3

[Aza Raskin [:aza]]

Yes, we should absolutely extend the grab target to the edge of the box.

Comment 4

[Ian Gilman [:iangilman]]

(In reply to comment #3)
> Yes, we should absolutely extend the grab target to the edge of the box.

Aza, please mark the patch with f+.

Comment 5

[Notlost]

confirmed on linux x86 ubuntu 10.10

Comment 6

[Kevin Hanes]

bugspam (moving b9 to b10)

Comment 7

[Kevin Hanes]

bugspam (removing b9)

Comment 8

[Ian Gilman [:iangilman]]

Comment on attachment 489064 [details] [diff] [review]
patch

Looks good. It appears the same bug exists on Mac and Windows as well... please update them too.

Comment 9

[Eevee (Evelyn Woods) [:eevee]]

Attachment: patch for all platforms

I've only got Linux handy, but this *should* work for win/mac.

Comment 10

[Ian Gilman [:iangilman]]

Comment on attachment 505331 [details] [diff] [review]
patch for all platforms

Looks good to me. Please package for checkin as per:

https://wiki.mozilla.org/Firefox/Projects/TabCandy/Work#Landing

Thank you for doing this!

Comment 11

[Kevin Hanes]

bugspam. Moving b10 to b11

Comment 12

[Kevin Hanes]

bugspam. Removing b10

Comment 13

[Eevee (Evelyn Woods) [:eevee]]

Attachment: patch with hg metadata

Comment 14

[Eevee (Evelyn Woods) [:eevee]]

Like so?

Comment 15

[Michael Yoshitaka Erlewine [:mitcho]]

You'll have to wait for approval first.

Comment 16

[Dietrich Ayala (:dietrich)]

Has this been tested on all platforms now?

Comment 17

[Patrick Walton (:pcwalton)]

(In reply to comment #16)
> Has this been tested on all platforms now?

I can test.

Comment 18

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 506069 [details] [diff] [review]
patch with hg metadata

a+ assuming it's been tested on win/lin/mac.

Comment 19

[Patrick Walton (:pcwalton)]

http://hg.mozilla.org/mozilla-central/rev/710deb1c54fb

Comment 20

[Tracy Walker [:tracy]]

verified with minefield build of 20110217