610573 - unable to run talos on builds after Oct 24th, fennec fails to terminate

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Joel Maher ( :jmaher ) (UTC -8)]

Talos runs are experiencing problems with fennec shutting down on android.  This is true for twinopen and tpan.  What happens is talos sets up a profile, runs talos with that profile and a webpage, outputs the results into a .txt file on the device and then shuts down.  The talos scripts wait for the process to terminate.

Here is the quit code this is called:
http://hg.mozilla.org/build/talos/file/ce9b0413fbf1/mobile_profile/extensions/electrolysis%40mozilla.org/chrome/content/quit.js

In testing this build from:
http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/2010-10-24-04-mozilla-central-android-r7/

I can get clean runs over and over again.  I even uninstalled and reinstalled fennec as well as the profile to ensure I wasn't testing with cached data.

Next I installed this build:
http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/2010-10-25-04-mozilla-central-android-r7/

and I couldn't even get the basic information about screen size from talos (because it fails to terminate the browser).  In addition, I installed Oct 27th build in case the 25th build was a known bad build and I had the same results as the Oct 25th build.  As a note this information gathering process (and termination) work on todays build (just when the test finished running the process wouldn't terminate).  

After hooking a monitor up to this, I watched the browser launch and do the test, then the browser would disappear.  looking in the process list, org.mozilla.fennec remains active.

This is blocking talos from running twinopen and tpan on the latest builds.

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

is this going to land today?

Comment 3

[Michael Wu [:mwu]]

(In reply to comment #2)
> is this going to land today?

I'll land it tonight.

Comment 4

[Michael Wu [:mwu]]

http://hg.mozilla.org/mozilla-central/rev/73473d404a53

Comment 5

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to comment #2)
> is this going to land today?

I wanted confirmation that this fixed the issue for you before landing it

Comment 6

[Michael Wu [:mwu]]

(In reply to comment #5)
> (In reply to comment #2)
> > is this going to land today?
> 
> I wanted confirmation that this fixed the issue for you before landing it

Well I guess we'll find out. Reopen please if this doesn't work out.

Comment 7

[Joel Maher ( :jmaher ) (UTC -8)]

I have verified this works on my local system.  Thanks for fixing such a complex issue and landing this patch!