610688 - Style buttons for popup notifications without secondary actions

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[:Margaret Leibovic]

Attachment: patch

Bug 610123 restored the default button styling to the buttons in popup notifications without secondary actions. However, we want these normal buttons to have the same updated style as the menu buttons.

Comment 1

[Dão Gottwald [:dao]]

Comment on attachment 489189 [details] [diff] [review]
patch

This seems right for OS X.

Why would we want this for Windows? The reason we started at all with the custom menu button styling on Windows was that we didn't have a reasonable default style (bug 509642, bug 581193). This isn't the case for non-menu buttons.

Comment 2

[:Margaret Leibovic]

(In reply to comment #1)
> Why would we want this for Windows? The reason we started at all with the
> custom menu button styling on Windows was that we didn't have a reasonable
> default style (bug 509642, bug 581193). This isn't the case for non-menu
> buttons.

I believe we want a custom button style for all arrow panels, but this is a first step. I talked to Stephen about it, and he's going to leave a comment once he decides what we should be doing.

Comment 3

[Dão Gottwald [:dao]]

(In reply to comment #2)
> (In reply to comment #1)
> > Why would we want this for Windows? The reason we started at all with the
> > custom menu button styling on Windows was that we didn't have a reasonable
> > default style (bug 509642, bug 581193). This isn't the case for non-menu
> > buttons.
> 
> I believe we want a custom button style for all arrow panels,

Again, I don't see why. It looks and feels considerable worse than native buttons on Windows. (See the last part of bug 606343 comment 20 for the reaction of a random person.)

OS X is different since the panels are black there, so native buttons don't fit.

Comment 4

[:Margaret Leibovic]

Attachment: patch (pinstripe only)

Here's a patch with only pinstripe styles. I'll file a separate bug if Stephen wants us to change the button styles on winstripe.

Comment 5

[Justin Dolske [:Dolske]]

Comment on attachment 489810 [details] [diff] [review]
patch (pinstripe only)

a+=me, but let's get a followup on file to figure out what (if anything) we want to do on Windows... Sounds like shorlander has some thoughts.

Comment 6

[:Margaret Leibovic]

http://hg.mozilla.org/mozilla-central/rev/898ef162e026

Filed bug 612690 as a follow-up.