Closed Bug 610736 Opened 12 years ago Closed 12 years ago

Port a number of recent places changes


(SeaMonkey :: Bookmarks & History, defect)

Not set


(Not tracked)



(Reporter: kairo, Assigned: kairo)




(1 file)

I have a list of recent places changes in Firefox I need to go through and see to port them to SeaMonkey.
Depends on: 424542
Depends on: 458026
Note that bug 574688 is only on the list for the sidebar changes, which are independent of the actual statusbar-realted changes.
Depends on: 574688
Depends on: 477882
Attached patch port those bugsSplinter Review
Due to bug 611001 not having been done, I needed to add the .markPageAsFollowedLink() somewhere else but I seem to have found the right spot, so that the test succeeds. I hope the other changes are easy to verify and not too controversial...
Attachment #489558 - Flags: review?(neil)
Oh, I forgot to mention that I took the chance to take care of the merging of the sidebarUtils as they have been practically identical for bookmarks and history anyhow.

As a side note, onBeforeLinkTraversal has been introduced for bug 575561, which is an app tab matter, but I saw errors in the console due to this method missing (when executing the markPageAsFollowedLink test), so I implemented it in a dummy version.
Comment on attachment 489558 [details] [diff] [review]
port those bugs

>+  // Called before links are navigated to to allow us to retarget them if needed.
>+  onBeforeLinkTraversal: function(originalTarget, linkURI, linkNode, isAppTab) {
>+    // We doesn't support app tabs yet but are seeing failures without this.
The method was added to nsIXULBrowserWindow.idl so a) the implementation belongs after setOverLink b) we don't need this comment but I guess you could add an nsIXULBrowserWindow heading instead to make it clearer.

>+               .filter(function (tag) tag.length > 0); // Kill empty tags.
[filter(function(tag) tag) would probably work.]
Attachment #489558 - Flags: review?(neil) → review+
Landed as
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.1b2
Blocks: 609034
Blocks: 631770
You need to log in before you can comment on or make changes to this bug.