610893 - Add post-commit hook to SVN, automatically creating JSON files after commit to product-details

Status: RESOLVED WONTFIX

(mozilla.org Graveyard :: Server Operations, task)

Description

[Fred Wenzel [:wenzel]]

Our product details library is edited in PHP files here:

http://viewvc.svn.mozilla.org/vc/libs/product-details/

When these files change, one must run ./export_json.php to create JSON data files for everyone to consume. If this step is missed, evil comes upon us.

We should add a post-commit hook in SVN that automatically runs the export_json script when there's a commit to the aforementioned directory.

Please let me know if that's enough information for you or if you need me to write some code for this.

Comment 1

[Fred Wenzel [:wenzel]]

(In reply to comment #0)
> We should add a post-commit hook in SVN that automatically runs the export_json
> script when there's a commit to the aforementioned directory.

It needs to run that script and commit the generated JSON files (if they differ), of course.

Comment 2

[Fred Wenzel [:wenzel]]

Jbalogh mentioned, committing out of a post-commit hook might not work. Another option for us would be to reject the commit if export_json would alter the JSON files (which means, the commit results in inconsistent JSON files and needs to be fixed).

Comment 3

[Reed Loden [:reed] (use needinfo?)]

If it's easier than IT getting a post-commit hook working, I can set up a cronjob on my server that just checks this every 5 min. or so and commits a new export_json if it is needed.

Comment 4

[Fred Wenzel [:wenzel]]

Thanks, I was considering something like that too, I use a similar thing on khan for auto-updating the L10n files on two projects.

Comment 5

[Aravind Gottipati [:aravind]]

Is this still needed?

Also, comment 3 kind of confused me.  Could you please explain what's needed better?

Comment 6

[Fred Wenzel [:wenzel]]

I think we're fine here. We're going to revamp the way product-details work in 2011 (or so I hope).

Comment 7

[Armen [:armenzg]]

wenzel any short term solution at sight?
We had to file bug 624658 to deal with more new locales.

Comment 8

[Fred Wenzel [:wenzel]]

Yea, I'll take a look at it today.