624658 - Add hi-IN, kk, mai, sr and ta locales to Tuxedo and product details

Status: RESOLVED FIXED

(Webtools :: Bouncer, defect)

Description

[Rail Aliiev [:rail]]

This bug is similar to bug 610708. 4.0b9 has 3 new locales, so adding bouncer entries using Tuxedo REST API didn't work as expected.

Please, could you add hi-IN, mai and ta locales to Tuxedo.

Thanks in advance!

Comment 1

[Armen [:armenzg]]

See also bug 610893 to see an attempt of fixing the core problem.

Note that in bug 610708#c8 I mention that an apache restart was needed to pick up the change.

Comment 2

[Fred Wenzel [:wenzel]]

"mai" is missing from product-details:

http://viewvc.svn.mozilla.org/vc/libs/product-details/localeDetails.class.php?view=markup

Please add that before there's a chance it can be available in Bouncer.

Then we can update Bouncer's data from SVN and it'll work. Thanks!

Comment 3

[Fred Wenzel [:wenzel]]

All right, I fixed the code so that it uses the product-details library and can be auto-updated. I'll file an IT bug to get this picked up.

Comment 4

[Armen [:armenzg]]

That is fantastic! Thanks wenzel :)

Comment 5

[Fred Wenzel [:wenzel]]

The code is done. When you fix comment 2, it'll be automatically picked up (at most 4 hours waiting time) by tuxedo.

Comment 6

[Rail Aliiev [:rail]]

(In reply to comment #5)
> The code is done. When you fix comment 2, it'll be automatically picked up (at
> most 4 hours waiting time) by tuxedo.

Unfortunately I can't fix localeDetails.class.php, Pascal, could you help here?

Comment 7

[Rail Aliiev [:rail]]

The final list of new locales is different I prepared in advance. Actually we have 5 new locales: hi-IN, kk, mai, sr, ta.

I had to add Bouncer entries manually to prevent a bottle neck here. Lowering the importance and removing bug 621199 from blocked by this bug list.

Comment 8

[Armen [:armenzg]]

For the following betas could we figure out a process to add new locales to that list?

I assume those locales arrive to our configs because they have been on the L10n dashboard and others before they get to us.

Pascal is there a wiki page or guideline that L10n follows to add a new locale to the dashboard et all? Could we add a checkpoint to add them to the list of product details?

Perhaps we can add a note on the following beta build notes to ask webdev or whoever to land the patch for us? This would not be ideal as I would prefer to get the ducks lined up before getting to us *if* it can be done.

comments/feedback?

Comment 9

[[e-mail] (:bhearsum)]

Perhaps Tuxedo could be more permissive, and automatically add locales that are missing when it gets a request to add a location referencing one.

Comment 10

[Fred Wenzel [:wenzel]]

(In reply to comment #9)
> Perhaps Tuxedo could be more permissive, and automatically add locales that are
> missing when it gets a request to add a location referencing one.

I don't think that'd be a good idea. Tuxedo is (currently) a locale consumer, not provider. If we convert Tuxedo into a one-stop shop^Wwebservice for product and locale data at some point, this could change (releng would push new products, versions, and perhaps locales to Tuxedo as our authoritative reference). But right now, product-details in SVN is where the locales live, and they are maintained by our L10n team. If they are not in there, they also won't show up on any of our websites, so adding them before releasing a version of Firefox in this locale is the right thing to do.

Comment 11

[[e-mail] (:bhearsum)]

OK, I can buy that. As long as we end up in a world where Bouncer additions don't fail whenever we add a locale, I'm happy. Whether that's automation, improved human process, or whatever -- doesn't matter to me.

Comment 12

[Rail Aliiev [:rail]]

At the moment all of the requested locales are available in http://viewvc.svn.mozilla.org/vc/libs/product-details/localeDetails.class.php?view=markup

Closing.