Closed Bug 610974 Opened 9 years ago Closed 9 years ago

Ensure places is enabled for places related tests

Categories

(Toolkit :: Places, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Attached patch The fixSplinter Review
In bug 608981 we want to enable building of places for Thunderbird for several reasons - to bring it closer to core and cut down on the differences, and to enable extensions to be able to try out different things.

However, at least for the moment, we want to disable places by default, so that we're not going to affect users by default, but we can try out different things.

As we're disabling places, all the places related tests will then fail, so this bug is requesting that we put in additional enabling of places where appropriate.

Basically, the attached patch does the enabling in the head_*.js files where places is used more than once in a directory, otherwise, just in the test file itself.
Attachment #489470 - Flags: review?
Attachment #489470 - Flags: review? → review?(sdwilsh)
Comment on attachment 489470 [details] [diff] [review]
The fix

>+++ b/toolkit/components/places/tests/unit/test_doSetAndLoadFaviconForPage.js
>@@ -110,7 +110,7 @@ var tests = [
>       iconsvc.setAndLoadFaviconForPage(this.pageURI, this.favicon.uri, true);
> 
>       try {
>-        prefs.clearUserPref("places.history.enabled");
>+        prefs.setBoolPref("places.history.enabled", true);
>       } catch (ex) {}
Lose the try-catch

>+++ b/toolkit/components/places/tests/unit/test_doSetAndLoadFaviconForPage_failures.js
>@@ -86,7 +86,7 @@ let tests = [
>     },
>     clean: function clean2() {
>       try {
>-        Services.prefs.clearUserPref("places.history.enabled");
>+        Services.prefs.setBoolPref("places.history.enabled", true);
>       } catch (ex) {}
ditto

r=sdwilsh
Attachment #489470 - Flags: review?(sdwilsh) → review+
Checked in: http://hg.mozilla.org/mozilla-central/rev/8ec78ba9e09c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in before you can comment on or make changes to this bug.