Enable building of places in Thunderbird, but disable history by default

RESOLVED FIXED in Thunderbird 3.3a2

Status

RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

unspecified
Thunderbird 3.3a2
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

8 years ago
To move the Thunderbird build closer to Firefox, and to easily enable interesting things like favicons for content tabs, we should start building places. Extensions should also be able to use it if they wish to.

I can't see a reason at the moment for us to enable storing of history by default, so I think we should disable it by default but keep reasonable defaults in place. I believe that favicon storing/usage will still work even if the history is disabled (I think it relies on other prefs).
Clarification question: can we do browser navigation (back/forward) w/o history?  Those seem like likely useful things in site-specific contentTabs.
(Assignee)

Comment 2

8 years ago
(In reply to comment #1)
> Clarification question: can we do browser navigation (back/forward) w/o
> history?  Those seem like likely useful things in site-specific contentTabs.

With places built, it should be the same as setting Firefox to "Never Remember History".

Without places, I'm not sure. Although you said earlier that it works on trunk but not 1.9.2...
(Assignee)

Comment 3

8 years ago
Created attachment 487731 [details] [diff] [review]
Enable places in Thunderbird

This patch enables building of places within Thunderbird, but history disabled by default.

It needs a core patch to pass tests, as the core tests assume history is enabled by default. I'll attach a patch in a moment that fixes all but one of those tests.

The remaining test that I haven't fixed currently hangs and I haven't worked out why yet.
(Assignee)

Comment 4

8 years ago
Created attachment 487733 [details] [diff] [review]
Force enabling of places in core xpcshell-tests

test_doSetAndLoadFaviconForPage_failures.js is the test with an issue here. It is currently disabled with an early return.
yes, ignore comment #1.
(Assignee)

Updated

8 years ago
Assignee: nobody → bugzilla
(Assignee)

Updated

8 years ago
Depends on: 610974
(Assignee)

Comment 6

8 years ago
Comment on attachment 487733 [details] [diff] [review]
Force enabling of places in core xpcshell-tests

The full patch is now on bug 610974.
Attachment #487733 - Attachment is obsolete: true
(Assignee)

Comment 7

8 years ago
Comment on attachment 487731 [details] [diff] [review]
Enable places in Thunderbird

With the patch in bug 610974, all the tests pass on try server. I believe this is everything we need.
Attachment #487731 - Flags: review?(philringnalda)
Comment on attachment 487731 [details] [diff] [review]
Enable places in Thunderbird

Looks good to me.
Attachment #487731 - Flags: review?(philringnalda) → review+

Comment 9

8 years ago
If places is enabled in TB, will this fix the following error (I see everytime I start TB)?

Error: Places database may be locked: [Exception... "Component returned failure code: 0x80040154 (NS_ERROR_FACTORY_NOT_REGISTERED) [nsIDocShellHistory.useGlobalHistory]"  nsresult: "0x80040154 (NS_ERROR_FACTORY_NOT_REGISTERED)"  location: "JS frame :: chrome://messenger/content/specialTabs.js :: anonymous :: line 170"  data: no]
File: chrome://messenger/content/specialTabs.js
Line: 172


Or is this unrelated?
(Assignee)

Comment 10

8 years ago
(In reply to comment #9)
> If places is enabled in TB, will this fix the following error (I see everytime
> I start TB)?

Most likely, though I haven't tested it yet.
(Assignee)

Updated

8 years ago
Depends on: 614550
(Assignee)

Comment 11

8 years ago
Just to keep folks updated, this landed but got backed out again because I hadn't taken account of the c++ tests - bug 614550 fixes the failure, so I'll attempt to re-land following that.
(Assignee)

Comment 12

8 years ago
Checked in: http://hg.mozilla.org/comm-central/rev/a42338acc7db
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
(Assignee)

Updated

8 years ago
Target Milestone: --- → Thunderbird 3.3a2
You need to log in before you can comment on or make changes to this bug.