611179 - [Versions page]Button name is incorrect in "Cancel Review Request" pop-up

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[krupa raj[:krupa]]

Attachment: screenshot

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.6; en-US; rv:1.9.2.12) Gecko/20101026 Firefox/3.6.12

steps to reproduce:
1. Load https://addons.allizom.org/z/en-US/developers/addon/228515/versions/
2. Click on "Cancel Review Request"
3. Notice the button in the pop-up

expected behavior:
As per http://people.mozilla.com/~chowse/drop/amo/devtools/v3/manage_addon/05_versions.png, the button name is "Cancel Review"

actual behavior:
The button in the pop-up is "Delete Add-on Version". See screenshot

Comment 1

[Jeff Balogh (:jbalogh)]

I recall pointing this out in a review.

Comment 2

[Gregory Koberger (:gkoberger)]

jbalogh: You pointed out that "Disabled" was called "Deleted" (or vice versa).  I guess I had multiple names wrong.

Comment 3

[Gregory Koberger (:gkoberger)]

Github: https://github.com/gkoberger/zamboni/commit/fe2aca1c5d9f811a36c8696f3ba60c1f0dbcdc31

Testing URL: https://addons.allizom.org/z/en-US/developers/addon/228515/versions/

Comment 4

[krupa raj[:krupa]]

verified @ https://addons.allizom.org/z/en-US/developers/addon/64250/versions/

Now, all the buttons have the right names. Also, thanks for providing the test link :)

Comment 5

[krupa raj[:krupa]]

Attachment: post-fix screenshot