Closed Bug 611715 Opened 9 years ago Closed 9 years ago

Rename tab.tabItem

Categories

(Firefox Graveyard :: Panorama, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 4.0b10

People

(Reporter: iangilman, Assigned: raymondlee)

Details

(Keywords: dev-doc-needed, Whiteboard: [cleanup][qa-][API])

Attachments

(1 file, 2 obsolete files)

We hang a TabItem off of xul:tabs, and currently we do it with the property "tabItem", but this is too generic for the context. I propose we change it to "_tabViewTabItem" to identify what it is, where it's from, and that it's not for general consumption.
If we're going to take an opportunity to rename things, though, why not _panoramaTabItem? Most code references are to TabView, now, but that may get confusing in the long run... might as well start to switch over now?
Whiteboard: [cleanup][qa-]
"tabview" seems alright as an internal name. I don't see us replacing all its occurrences with "panorama".
Assignee: nobody → raymond
Raymond: ping?
(In reply to comment #3)
> Raymond: ping?

Dao: I agree with keeping "tabview" and change tab.tabItem to tab._tabViewTAbItem.
Alright, are you going to write the patch?
Not at the moment, since it's a not blocker.
This should be done asap (in fact, it shouldn't have landed this way), since the later it gets done the more extensions will be affected.
You are right.  Let me work on this next then.
Attached patch v1 (obsolete) — Splinter Review
Attachment #502750 - Flags: review?(ian)
Status: NEW → ASSIGNED
(In reply to comment #9)
> Created attachment 502750 [details] [diff] [review]
> v1

Passed Try
Comment on attachment 502750 [details] [diff] [review]
v1

Looks great!
Attachment #502750 - Flags: review?(ian) → review+
Attachment #502750 - Flags: approval2.0?
It would be nice to land this as soon as we can.  As mentioned in comment #7, the later it gets done the more extensions will be affected.
We've already told add-on authors that we're frozen; I'm fine taking this, but I would like to see a blog post explaining what's changed or some outreach to add-on developers.

Adding Jorge.
Attachment #502750 - Flags: approval2.0? → approval2.0+
Attachment #502750 - Attachment is obsolete: true
Jorge: Basically, we change a name of the reference from tab.tabItem to tab._tabViewTabItem.  Extensions can access the panorama data related to a browser browser using tab._tabViewTabItem instead of tab.tabItem.
Keywords: checkin-needed
(In reply to comment #15)
> Jorge: Basically, we change a name of the reference from tab.tabItem to
> tab._tabViewTabItem.  Extensions can access the panorama data related to a
> browser browser using tab._tabViewTabItem instead of tab.tabItem.

Though it should be noted that this is no blessed API.

We should probably add a TabView.getItemForTab method.
http://hg.mozilla.org/mozilla-central/rev/847b7c31b8a5
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 4.0b10
(In reply to comment #16)
> Though it should be noted that this is no blessed API.

Definitely. Work on "a real API" has been punted past fx4.
Whiteboard: [cleanup][qa-] → [cleanup][qa-][API]
Attached patch Patch for check-in (obsolete) — Splinter Review
Updated tab.tabItem to tab._tabViewTabItem
Attachment #503063 - Attachment is obsolete: true
Comment on attachment 503396 [details] [diff] [review]
Patch for check-in

This doesn't seem to belong in this bug.
Attachment #503396 - Attachment is obsolete: true
Attachment #503063 - Attachment is obsolete: false
This might be worth a mention on the Firefox 4 MDC page.
Keywords: dev-doc-needed
Hm, this is not presently documented at all. Any design notes or anything for the panorama view from a developer standpoint I can use to add reference docs for this stuff?
(In reply to comment #22)
> Hm, this is not presently documented at all. Any design notes or anything for
> the panorama view from a developer standpoint I can use to add reference docs
> for this stuff?

Unfortunately we never got around to making an official API, so everything that's in Panorama is subject to change in the future. That said, our code documentation is here:

http://hg.mozilla.org/labs/tabcandy/raw-file/tip/content/doc/index.html

Let me know if you have questions.
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.