Can't open URIs from the command line

RESOLVED FIXED in Thunderbird 3.3a2

Status

Thunderbird
OS Integration
--
major
RESOLVED FIXED
8 years ago
8 years ago

People

(Reporter: jcranmer, Assigned: protz)

Tracking

(Blocks: 1 bug, {regression})

Trunk
Thunderbird 3.3a2
x86
Linux
regression
Dependency tree / graph

Firefox Tracking Flags

(blocking-thunderbird5.0 alpha2+)

Details

Attachments

(1 attachment)

(Reporter)

Description

8 years ago
When I try doing mozilla/dist/bin/thunderbird -no-remote news:rec.games.pinball, I get an error to the effect that said URI is not a file.

After doing some research, it looks like bug 287345 incorrectly assumed that anything hitting that statement was a file and not a URI.

I believe this impacts shell integration for Linux, but I can't say about Windows or Mac OS X.
(Reporter)

Updated

8 years ago
blocking-thunderbird5.0: --- → ?
blocking-thunderbird5.0: ? → alpha2+
(Assignee)

Comment 1

8 years ago
Created attachment 496775 [details] [diff] [review]
Patch (standard8's idea)

Bug 287345 introduced the issue probably, so what we do here is just revert the previous behavior in case the code from bug 287345 failed to take effect.
Assignee: nobody → jonathan.protzenko
Status: NEW → ASSIGNED
Attachment #496775 - Flags: review?(bugzilla)
Blocks: 549734
Comment on attachment 496775 [details] [diff] [review]
Patch (standard8's idea)

Although we could try being a URI first, and then try and be a file, but I don't think it really matters too much.
Attachment #496775 - Flags: review?(bugzilla) → review+
(Assignee)

Updated

8 years ago
Keywords: checkin-needed
(Assignee)

Comment 3

8 years ago
checked-in http://hg.mozilla.org/comm-central/rev/2e4b1b429e5d
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a2
Should this fix be in http://mxr.mozilla.org/comm-central/source/mailnews/base/src/nsMailNewsCommandLineHandler.js instead? I think SeaMonkey would be happy to get it too.
(actually, never mind -- that file wouldn't handle your command-line at any rate.) We really should have a proper spec for our command-line stuff. :/
You need to log in before you can comment on or make changes to this bug.