612053 - clicking a few pixels down from "Plugins" makes "Available Updates" or "Recent Updates" pane appear

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Frank Yan (:fryn)]

STR:
1. Open Add-ons Manager.
2. Click when the cursor placed a few pixels down from the "Plugins" pane label.

Expected Results:
Nothing happens.

Actual Results:
The "Recent Updates" label and pane appears.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Looks like it depends on some settings but for me the "Available Updates" pane is shown.

Comment 2

[Alice0775 White]

Here WORKARUND maybe works.

.category[disabled="true"]
{
  border-top: 0px !important;
  border-bottom: 0px !important;
}

Comment 4

[Frank Yan (:fryn)]

Attachment: patch

Removes border when disabled.

Comment 5

[Frank Yan (:fryn)]

(In reply to comment #2)
> .category[disabled="true"]
> {
>   border-top: 0px !important;
>   border-bottom: 0px !important;
> }

Thanks, Alice, for the suggested fix.

Comment 6

[Frank Yan (:fryn)]

Pushed.

http://hg.mozilla.org/mozilla-central/rev/c566b1cd7df8

Comment 7

[Frank Yan (:fryn)]

Target Milestone should be mozilla2.0b11, but it's not available as an option at the moment, so I'll fill that in later.

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Verified fixed with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b11pre) Gecko/20110127 Firefox/4.0b11pre

I don't think that we need a manual testcase here. Worth spending time on an automated one?

Comment 9

[Frank Yan (:fryn)]

(In reply to comment #8)
> I don't think that we need a manual testcase here. Worth spending time on an
> automated one?

I don't think so. Trivial bug. Better to have engineering resources working on writing tests for more critical functionality in the Add-ons Manager.