612679 - Order of the product is not the same for drop down select and multi-select

Status: VERIFIED FIXED

(Socorro :: Webapp, task)

Description

[David Burns :automatedtester]

The product list is not in the same order between the product selects on http://crash-stats.stage.mozilla.com/query.

They should be.

Comment 1

[David Burns :automatedtester]

disabled failing test in r78207

Comment 2

[Brandon Savage [:brandon]]

The issue here is that the dropdown menu is generated by using the product weight to define the order, while the branch data is used for the multiselect, which is alphabetical. Do you want us to use the weight here in both?

Comment 3

[Chris Howse [:chowse]]

(In reply to comment #2)
> Do you want us to use the weight here in both?

I'd lean towards yes, provided we can put a divider between the weighted groups, e.g.:

+-----------------+
|                 |
|  All            |
|  -------------  |
|  Firefox 7.0a1  |
|  Firefox 6.0a2  |
|  Firefox 5.0b1  |
|  Firefox 4.0    |
|  -------------  |
|  Firefox ...    |
|  Firefox ...    |
|                 |
+-----------------+

The non-top choices are sorted alphabetically, so this should be enough to 1.) get to the most common version choices quickly while 2.) still making it easy to find a specific version.

Also, make the <select> tall enough so that you can see all the top choices and a few of the remainder. In the above example, that'd be 9 rows tall.

Comment 4

[Laura Thomson :laura]

What chowse describes in comment 3 is how things are now implemented in the drop down.

What remains to do is to make the multi-select have the same order.

Comment 5

[Schalk Neethling [:espressive]]

Sent pull request :: https://github.com/mozilla/socorro/pull/466

TEST CASE
---------

Head over to the search page. The version multi select currently simply list version numbers from highest to lowest. That does not match the way versions are displayed in the versions drop down in the navigation.

After the fix this will now also be sorted by featured and older versions. If you select a product and no version information was found for the product, a message will be displayed informing the user of this. Previously this was causing a silent javascript error.

The height of the multi selects have also been increased to show a greater number of versions without scrolling.

Comment 6

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/9f08b665bef7d34a4a22b2597be6e2ecca2c5374
Merge pull request #466 from ossreleasefeed/update-multi-select-on-query-page-612679

sorting versions by featured and older versions fixes bug 612679

Comment 7

[Matt Brandt [:mbrandt]]

Attachment: qa - text doen't fit

Reopening: the text is sorted correctly (yay-woot!) however it has been shifted to right and no longer fits in the multi-select.

Comment 8

[Schalk Neethling [:espressive]]

updated pull request :: https://github.com/mozilla/socorro/pull/473

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/c7d5dbdd1f8fd4706523cf4c8f8f043250f86621
remove left padding from optgroups and increase width fixes bug 612679

https://github.com/mozilla/socorro/commit/4b1ef270fcd967beb84e48d4a000ba0a96948e98
Merge pull request #473 from ossreleasefeed/fix-width-multiselect-search-612679

remove left padding from optgroups and increase width fixes bug 612679

Comment 10

[[github robot]]

Commit pushed to stage at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/e9391180576a936e57246893c31b0711dd4e9bfa
remove left padding from optgroups and increase width fixes bug 612679

Comment 11

[Matt Brandt [:mbrandt]]

Attachment: qa - verified

QA verified - thx espressive - wicked quick fix!

Comment 12

[Florin Strugariu [:Bebe]]

Attachment: screenshot with the product items in different order

Comment 13

[Florin Strugariu [:Bebe]]

This bug refers to the product drop down select and multi-select.
This areas contain the same items but in different order.
They should be in the same order

Reopening this bug(see screen shot)

Comment 14

[Schalk Neethling [:espressive]]

Sent pull request :: https://github.com/mozilla/socorro/pull/574

TEST CASE
---------

Both sets of products are now sorted by product weight and hence the order should now match.

Comment 15

[[github robot]]

Commits pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/bdf7d991d79ba4594166780c9f0d46b43126cfce
sorting products by weight fixes bug 612679

https://github.com/mozilla/socorro/commit/676710103a22bd383d1798ff0d3f7bf3e4874e84
Merge pull request #574 from ossreleasefeed/update-version-select-dropdown-612679

sorting products by weight fixes bug 612679

Comment 16

[Matt Brandt [:mbrandt]]

Attachment: qa - verified

QA verified on stage - Both sets of products are now sorted by product weight and hence the order should now match.