690150 - Fix version sort on home page

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[[:jberkus] Josh Berkus]

We now have our first 10.0 version.

Currently on the home page, in the Version selector, 10.0a1 is sorting to the *bottom* of the list.  This is an obvious sorting problem.

The new product_versions has a sort column, so we could be relying on a database sort to get proper sorting.  However, this needs to wait for us to move Nightly/Aurora over to newtcbs. Hence, this bug is dependant on that completing.

Comment 1

[Schalk Neethling [:espressive]]

https://github.com/mozilla/socorro/pull/99 : can be tested here:

https://espressive-dev.allizom.org/products/Firefox

Comment 2

[Laura Thomson :laura]

Brandon, can you review please?

Comment 3

[Schalk Neethling [:espressive]]

Added explicit casting as suggested by [:lonnen]

Comment 4

[[github robot]]

Commit pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/0d37bbdeb15302fe5d3d2a933744895d79b1d8db
Merge pull request #99 from ossreleasefeed/frontpage

fixes bug 690150 - sort order on front page

Comment 5

[Matt Brandt [:mbrandt]]

Attachment: Version sort order

> comment 0: 10.0a1 is sorting to the *bottom* of the list.
QA verified on dev. The version sort order is such that 10.x is at the top of the list now.

Comment 6

[[github robot]]

Commit pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/c091798133a7e5ba5a5a0d675d31da1a49ab7050
back out due to regressions bug 690150

Comment 7

[[github robot]]

Commit pushed to https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/ed83623ab3c81af6ae1b9142b776ecf2c2035c3b
back out due to regressions bug 690150

Comment 8

[Robert Helmer [:rhelmer]]

We hit a few regressions in the 2.3.2 push:

1) sorting the dashboard versions breaks graph order
2) sort function should be defined somewhere other than layout view 

We noticed #2 because we had a different bug in which "SeaMonkey" was not being matched case-insensitively, so the branch in this code where there are no featured versions was hit and we threw an error (function not defined).

Comment 9

[Schalk Neethling [:espressive]]

[:rhelmer], [:mbrandt] Please let me know when the changes has been made to move the sorting to the DB and I will remove the changes made here from the view.

Comment 10

[Schalk Neethling [:espressive]]

This is fixed now correct?

Comment 11

[Schalk Neethling [:espressive]]

Are there still changes that needs to be removed from the view?

Comment 12

[Schalk Neethling [:espressive]]

None of the changes in https://github.com/mozilla/socorro/pull/99/files seems to still be present, marking this as resolved.