613195 - No keyword detection for missing attachment feature

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Joe Sabash [:JoeS1]]

Discovered in litmus testing:
Mozilla/5.0 (Windows NT 5.1; rv:2.0b8pre) Gecko/20101116 Thunderbird/3.3a1

I see no keyword detection at all.
Also on current trunk.

Comment 1

[Ludovic Hirlimann [:Usul]]

Error: uncaught exception: [Exception... "Operation is not supported"  code: "9" nsresult: "0x80530009 (NS_ERROR_DOM_NOT_SUPPORTED_ERR)"  location: "chrome://messenger/content/messengercompose/MsgComposeCommands.js Line: 1361"]

Standard8 is that what you saw in your error console ?

Comment 2

[Ludovic Hirlimann [:Usul]]

Gary can you try to ind the regression window  ?

str : open a message compose windows type

please find attached 

I think It regressed on trunk during October but I'm not sure.

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

(In reply to comment #2)
> Gary can you try to ind the regression window  ?

Taking it on.. Nice to be back :)

Comment 4

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Tested on Windows 7, comm-central builds.

2010-10-10 shows the missing attachment bar.
2010-10-16 to 2010-10-19 cannot be tested as composition was broken.
2010-10-20 does not show the bar at all, but composition was working again.

Referring to http://hg.mozilla.org/comm-central/pushloghtml?startdate=2010-10-19&enddate=2010-10-20 , seems like the fix for bug 605140 might be related.

Comment 5

[Jonathan Protzenko [:protz]]

You're using the global document variable to create a DOM node that you're trying to insert into a content document or whatever. The fix (I think) is to replace document.createTextNode with mailBodyNode.ownerDocument.createTextNode

I'll try this on Monday see if it fixes the issue.

Comment 6

[Jonathan Protzenko [:protz]]

Attachment: Fixes the issue at least on my computer!

This seems to fix the issue. I've had exactly the same problem in some extension of mine, I was happily inserting nodes created through the global (XUL) document into the inner (content) document, which seems to be wrong nowadays.

Comment 7

[[e-mail]]

(In reply to comment #6)
> I was happily inserting nodes created through the global
> (XUL) document into the inner (content) document, which seems to be wrong
> nowadays.
Hasn't it always been wrong, just inconsistently enforced?

Comment 8

[Jonathan Protzenko [:protz]]

Yes, I'd say this was a pretty big piece of luck these things used to work. They should never have!

Comment 9

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/954326b49160