613315 - Cu.getGlobalForObject should unwrap wrappers

Status: RESOLVED DUPLICATE of bug 736316

(Core :: XPConnect, defect)

Description

[:Gavin Sharp [email: [e-mail]]]

Using Cu.getGlobalForObject on wrappers seems to produce very strange results, e.g. returning the current global (of the wrapper?) rather than the global of the underlying object.

mrbkap suggests that nsXPCComponents_Utils::GetGlobalForObject() needs to do some unwrapping magic before just calling into JS_GetGlobalForObject.

Comment 1

[Jason Orendorff [:jorendorff]]

...And then re-wrapping afterwards, of course.

Cc-ing Waldo since this is his baby. Also I want to ask him to consider the ramifications for removing JSObject::parent when fixing this. :)

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Attachment: strawman

This seems to get me the behavior that I want. I don't understand the security implications of this, or what the "re-wrapping" from comment 1 would entail, though.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Attachment: strawman, v2

This is mostly guesswork :)

Comment 4

[Jeff Walden [:Waldo]]

Comment on attachment 492281 [details] [diff] [review]
strawman, v2

Seems reasonable.  I assume none of the methods here are fallible so as to need testing for null return or something?  (I didn't look.)

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 492281 [details] [diff] [review]
strawman, v2

Looks good, thanks.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Attachment: updated patch

Comment 7

[Bobby Holley (:bholley)]

I'm pretty sure I fixed this over in bug 736316.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

sure looks like it!