613438 - Traceback: ValueError: unsupported format character 'S' (0x53) at index 45 on search-tools RSS feed

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect, P2)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

https://addons.allizom.org/pl/firefox/search-tools/video/format:rss is traceback-inducing:

Traceback (most recent call last):

  File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/core/handlers/base.py", line 100, in get_response
    response = callback(request, *callback_args, **callback_kwargs)

  File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/contrib/syndication/views.py", line 34, in __call__
    feedgen = self.get_feed(obj, request)

  File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/contrib/syndication/views.py", line 106, in get_feed
    description = self.__get_dynamic_attr('description', obj),

  File "/data/amo_python/www/prod/zamboni/vendor/src/django/django/contrib/syndication/views.py", line 69, in __get_dynamic_attr
    return attr()

  File "/data/amo_python/www/prod/zamboni/apps/browse/feeds.py", line 129, in description
    return _(u'Search tools relating to %s') % self.category.name

ValueError: unsupported format character 'S' (0x53) at index 45

Comment 2

[Kumar McMillan [:kumar]]

Aha, the translator made a typo and copied the format string incorrectly.  The fix has been committed to svn here https://svn.mozilla.org/addons/trunk/site/app/locale/pl/LC_MESSAGES/messages.po

The fix is near the bottom of the page at:

#. L10n: %s is a category name.
#: apps/browse/feeds.py:129
msgid "Search tools relating to %s"
msgstr "Narzędzia wyszukiwania związane z kategorią %s"

(note the lower case %s which should fix it)


I'm not sure when this will show up on the site.  clouserw maybe knows?

Comment 3

[Wil Clouser [:clouserw]]

at some point in the future after I merge out l10n

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://addons.allizom.org/pl/firefox/search-tools/video/format:rss.