613443 - msgCompSMIMEOverlay.xul: remove useless |insertbefore="button-save"|

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Serge Gautherie (:sgautherie)]

(SeaMonkey) Bug 509209 removed |insertbefore="saveSeparator"|, without replacing it.

http://bonsai.mozilla.org/cvsquery.cgi?module=ThunderbirdTinderbox&sortby=Date&hours=2&date=explicit&mindate=2003-05-08+15%3A41&maxdate=2003-05-08+15%3A41
Thunderbird had replaced it with |insertbefore="button-save"|.

Any reason why SM would not want that too?

This is 1 of the (only) 2 differences which remain between SM and TB...

Comment 1

[Serge Gautherie (:sgautherie)]

I tried |insertbefore="button-attach"| and |insertafter="button-save"| in both SM and TB,
but neither makes a difference: the security button remains where it is (by default), between "button-attach" (or "spellingButton" in SM) and "button-save".

http://mxr.mozilla.org/comm-central/source/mail/components/compose/content/messengercompose.xul
http://mxr.mozilla.org/comm-central/source/suite/mailnews/compose/messengercompose.xul

Ah, I guess the 'insert*' attribute is overruled by
http://mxr.mozilla.org/comm-central/search?string=button-security&case=1&find=%2Fmessengercompose%5C.xul%24
{
/mail/components/compose/content/messengercompose.xul
    * line 633 -- defaultset="button-send,separator,button-address,spellingButton,button-attach,button-security,button-save,spring"
    * line 635 -- defaultset="button-send,separator,button-address,spellingButton,button-attach,button-security,button-save"
/suite/mailnews/compose/messengercompose.xul
    * line 589 -- defaultset="button-send,separator,button-address,button-attach,spellingButton,button-security,separator,button-save,spring,throbber-box"
}

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) Just remove it [Checked in: Comment 4]

Comment 3

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 500302 [details] [diff] [review]
(Av1) Just remove it
[Checked in: Comment 4]

Yeah, I've run into that before, too.

I think you can do some fun javascript to place it where you want, but if you'ld rather just remove the insertbefore, that sounds fine by me.

Comment 4

[Serge Gautherie (:sgautherie)]

Comment on attachment 500302 [details] [diff] [review]
(Av1) Just remove it
[Checked in: Comment 4]

http://hg.mozilla.org/comm-central/rev/de751c7cef58