Closed Bug 613502 Opened 9 years ago Closed 9 years ago

Map <article> like we do aria role "article"

Categories

(Core :: Disability Access APIs, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: davidb, Assigned: davidb)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Spun off bug 610650. Users normally navigate from heading to heading anyway. Exposing article as a landmark doesn't gain us anything.
So role:ROLE_DOCUMENT
Default state:STATE_READONLY
Attached patch patchSplinter Review
Our readonly state setting is sorta convoluted in general. We probably want a clean up bug for it.
Attachment #491921 - Flags: review?(surkov.alexander)
Attachment #491921 - Flags: review?(marco.zehe)
Comment on attachment 491921 [details] [diff] [review]
patch


>+  } else if (mContent && mContent->Tag() == nsAccessibilityAtoms::article) {

you don't need to check mContent

>+    // we want <article> to behave like a document in terms of readonly state

Use capital letter and dot in the end.

>     SimpleTest.waitForExplicitFinish();
>     addA11yLoadEvent(doTest);
>@@ -52,12 +57,18 @@
>     title="Expose non-editable documents as readonly, regardless of role">
>      Mozilla Bug 467387
>   </a>

add link to the bug

>   <p id="display"></p>
>   <div id="content" style="display: none"></div>
>   <pre id="test">
>   </pre>

and here

in the future we'd like to share nsARIAMap for ARIA and HTML5 I think
Attachment #491921 - Flags: review?(surkov.alexander) → review+
Comment on attachment 491921 [details] [diff] [review]
patch

>+  <article id="article">an article</article>
>   <article id="document" role="document">a document</article>

Maybe morph this into a test for landmark role "main", otherwise the ARIA override is no longer a true override.
Attachment #491921 - Flags: review?(marco.zehe) → review+
(In reply to comment #3)

> in the future we'd like to share nsARIAMap for ARIA and HTML5 I think

Yes, and possibly rename it.
http://hg.mozilla.org/mozilla-central/rev/d0a46bfe92d5 (a=davidb)
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
You need to log in before you can comment on or make changes to this bug.