613748 - Keyboard inputs do not work when tab-modal alerts are open in another tab

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect)

Description

[Josh Tumath]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b8pre) Gecko/20101120 Firefox/4.0b8pre
Build Identifier: 

Keyboard inputs do not work when tab-model alerts are open in another tab.

Reproducible: Always

Comment 1

[Nikita Popov]

Cannot reproduce on Mozilla/5.0 (Windows NT 6.1; rv:2.0b8pre) Gecko/20101120 Firefox/4.0b8pre.

If I run "javascript:alert(1)" on google.com homepage and do not discard it, I can still write in here.

Comment 2

[Josh Tumath]

Then maybe this bug has a more specific problem. Here is how to reproduce it:-

1. Open http://acid3.acidtests.org/
2. When the test completes, click on "A" to open the alert.
3. Go to the tab with this bugzilla page in it, and try to type in the comments textarea.

Comment 3

[Nikita Popov]

Confirming with the Acid3 testcase.

Comment 4

[Nikita Popov]

Attachment: Testcase

As seen in this testcase the bug does not occur when using a link (<a>), but does occur when using a <h1> or any other element I have tested.

Comment 6

[Justin Dolske [:Dolske]]

Eww. We should probably fix this for beta 8.

Comment 7

[Ed Lee :Mardak]

Seems like the alert needs to come from an onclick handler and not just a plain alert:

breaks:

data:text/html,<p onclick="alert(0)">Foo</p>

okay:

data:text/html,<script>alert(0)</script>

Comment 8

[Ed Lee :Mardak]

Something interesting I noticed when clicking on Bugzilla's URL data URI warning..

Fails with href:

data:text/html,<a onclick="confirm(0)">Foo</a>

Happens to work when there's no href (like with bugzilla):

data:text/html,<a href="/" onclick="confirm(0)">Foo</a>

Comment 9

[Neil Deakin]

What is happening is that nsPresShell::sDontRetargetEvents is being set (to prevent recursion) but it isn't being cleared until after the modal prompt closes
thus, events don't get retargeted to the right focused window.

This should be changed to use an argument instead of a global flag.

Comment 10

[Neil Deakin]

Attachment: Patch, not extensively tested

Let's try out this patch to see if it fixes some issues.

Comment 11

[Justin Dolske [:Dolske]]

Attachment: Patch v.2

Oops, Enn's patch needed one obvious change to nsDOMWindowUtils.cpp to compile. But WFM with the testcase here.

Comment 12

[Justin Dolske [:Dolske]]

Comment on attachment 492469 [details] [diff] [review]
Patch v.2

bz suggested smaug would be best to look at this. FWIW, I pushed this to try, seems to be doing fine there.

Also noted that this changes a (native) API, so I'll email drivers. Seems like this should ok, it's a big win (tab-modal prompts), and should only potentially effect binary addons (and the fix for them is easy).

Comment 13

[Justin Dolske [:Dolske]]

Sent email to releave-drivers for approval of the interface change, a=bsmedberg.

Comment 14

[Justin Dolske [:Dolske]]

Pushed http://hg.mozilla.org/mozilla-central/rev/34447b39697a

Thanks Enn!