Port PYTHON_VERSION check to c-c configure.in

RESOLVED FIXED in Thunderbird 3.3a2

Status

MailNews Core
Build Config
--
trivial
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Callek, Assigned: Callek)

Tracking

Trunk
Thunderbird 3.3a2
Dependency tree / graph
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

v1
970 bytes, patch
Robert Kaiser
: review+
sgautherie
: feedback-
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
Created attachment 492131 [details] [diff] [review]
v1

This bug ports relevant and missing parts of:

* Bug 427750 (http://hg.mozilla.org/mozilla-central/rev/ad1cb31760d0)
* Bug 427750 (http://hg.mozilla.org/mozilla-central/rev/0611a19fee9d)
* Bug 550959 (http://hg.mozilla.org/mozilla-central/rev/bb200e1f52b4)
* Bug 599737 (http://hg.mozilla.org/mozilla-central/rev/08f79fca7386)

This bug done primarily as sync, since nothing directly relies on it.
Attachment #492131 - Flags: review?(kairo)
Comment on attachment 492131 [details] [diff] [review]
v1

> This bug ports relevant and missing parts of:

That's arguable:

> * Bug 427750 (http://hg.mozilla.org/mozilla-central/rev/ad1cb31760d0)
> * Bug 427750 (http://hg.mozilla.org/mozilla-central/rev/0611a19fee9d)

Not "missing" but "intentional":
see bug 427750 comment 26 and bug 427750 comment 27.

> * Bug 550959 (http://hg.mozilla.org/mozilla-central/rev/bb200e1f52b4)
> * Bug 599737 (http://hg.mozilla.org/mozilla-central/rev/08f79fca7386)

These two are unrelated.

> This bug done primarily as sync, since nothing directly relies on it.

Indeed.
Attachment #492131 - Flags: feedback-
Severity: normal → trivial
Status: NEW → ASSIGNED
Flags: in-testsuite-
OS: Windows XP → All
Hardware: x86 → All
Version: unspecified → Trunk
(Assignee)

Comment 2

7 years ago
(In reply to comment #1)
> Comment on attachment 492131 [details] [diff] [review]
> v1
> 
> > This bug ports relevant and missing parts of:
> 
> That's arguable:
> 
> Not "missing" but "intentional":
> see bug 427750 comment 26 and bug 427750 comment 27.
> 

Intentional by you, sure. But I forgot to talk with Robert about it.

> > This bug done primarily as sync, since nothing directly relies on it.
> 
> Indeed.

And given the large large amount of diff between m-c and c-c arbitrary changes in configure.in I do not agree with atm. [stuff we directly _removed_ I won't argue over and leave removed though, for now]
(In reply to comment #2)

> Intentional by you, sure. But I forgot to talk with Robert about it.

All I was reminding is that my patch got r+ from both of you, at the time.

> And given the large large amount of diff between m-c and c-c arbitrary changes
> in configure.in I do not agree with atm.

You can disagree: bugs are there to discuss them, if needed.

And that's all I'm doing here: just being explicit about what/why happened.
I gave f-, yet I won't argue more if KaiRo gives r+ now :-|

> [stuff we directly _removed_ I won't
> argue over and leave removed though, for now]

In this case, not adding it was not to have to remove it, as it is (or at least was) unused.

Maybe I'm just missing an explanation about why you want to sync/add this block that c-c doesn't need (atm), or does it?
As in "what is the 'relevant' part of your comment 0?".
Depends on: 427750

Comment 4

7 years ago
Comment on attachment 492131 [details] [diff] [review]
v1

whatever. let's error out as soon as possible.
Attachment #492131 - Flags: review?(kairo) → review+

Comment 5

7 years ago
Patch checked-in : http://hg.mozilla.org/comm-central/rev/c8adcdc5e20c
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.3a2
You need to log in before you can comment on or make changes to this bug.