Closed Bug 613970 Opened 9 years ago Closed 9 years ago

l10n repack scripts should retry anything that touches the network

Categories

(Release Engineering :: General, defect, P3)

All
macOS
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bhearsum, Assigned: bhearsum)

References

Details

(Whiteboard: [automation][l10n])

Attachments

(1 file, 1 obsolete file)

Just like we retry tagging when it fails to push we should retry any operations that touch the network when they fail -- hg out/push/pull/clone. Similar to bug 613953 but more general.
Blocks: 478420
Whiteboard: [automation][l10n]
Priority: -- → P5
Planning to fix this this quarter.
Assignee: nobody → bhearsum
Status: NEW → ASSIGNED
Priority: P5 → P3
Duplicate of this bug: 628390
This patch sprinkles around retry across l10n scripts. I originally tried to avoid putting them in the lib/ parts, but that had the unfortunate side effect of eg, redoing the entire repack if the upload fails.

While I was poking around I also changed the error output in such a way that it should fix bug 628392.
Attachment #525082 - Flags: review?(catlee)
Attachment #525082 - Flags: review?(armenzg)
Comment on attachment 525082 [details] [diff] [review]
retry l10n stuff, fix error output

It looks straight forward.
Thanks for fixing the error reporting at the end.
Attachment #525082 - Flags: review?(armenzg) → review+
Comment on attachment 525082 [details] [diff] [review]
retry l10n stuff, fix error output

Moving this to Rail to expedite it.
Attachment #525082 - Flags: review?(catlee) → review?(rail)
Changed the format of the per-locale printouts to be prettier, and added an explicit list of locales that failed at the end.
Attachment #525082 - Attachment is obsolete: true
Attachment #525427 - Flags: review?(rail)
Attachment #525082 - Flags: review?(rail)
Attachment #525427 - Flags: review?(rail) → review+
Comment on attachment 525427 [details] [diff] [review]
output tweaked slightly

Landed this
Attachment #525427 - Flags: checked-in+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks: 613953
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.