Closed Bug 614058 Opened 9 years ago Closed 9 years ago

DocumentFragment.isEqualNode regression with child nodes

Categories

(Core :: DOM: Core & HTML, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla2.0b8
Tracking Status
blocking2.0 --- final+

People

(Reporter: WeirdAl, Assigned: bzbarsky)

References

()

Details

(Keywords: regression, testcase)

Attachments

(1 file)

var f1 = document.createDocumentFragment(); 
f2 = f1.cloneNode(true); 
f1.appendChild(document.createElement("foo"));
f1.isEqualNode(f2)

In FF3.6, this returns false.
In FF4.0b7, this returns true, incorrectly.

cc'ing peterv and bzbarsky for bug 560273 and bug 562688, which from hg blame are the most likely to have caused this bug.

I spotted this by code inspection.
blocking2.0: --- → ?
Ah, definitely a regression from bug 562688.
Assignee: nobody → bzbarsky
No longer blocks: 560273
Priority: -- → P1
Attachment #492778 - Flags: review?(jst)
Whiteboard: [need review]
Attachment #492778 - Flags: review?(jst) → review+
blocking2.0: ? → final+
Attachment #492778 - Flags: approval2.0?
Attachment #492778 - Flags: approval2.0?
Whiteboard: [need review] → [need landing]
blocking2.0: final+ → ---
Gavin, please don't remove blocking+ flags?  ;)
blocking2.0: --- → final+
Pushed http://hg.mozilla.org/mozilla-central/rev/2af96a164c62
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [need landing]
Target Milestone: --- → mozilla2.0b8
Backed out the patch for being in the range of bug 615736
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [need landing]
Pushed http://hg.mozilla.org/mozilla-central/rev/80426f61cb13

Tree is green.
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Whiteboard: [need landing]
You need to log in before you can comment on or make changes to this bug.