Closed
Bug 614058
Opened 14 years ago
Closed 14 years ago
DocumentFragment.isEqualNode regression with child nodes
Categories
(Core :: DOM: Core & HTML, defect, P1)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla2.0b8
| Tracking | Status | |
|---|---|---|
| blocking2.0 | --- | final+ |
People
(Reporter: WeirdAl, Assigned: bzbarsky)
References
()
Details
(Keywords: regression, testcase)
Attachments
(1 file)
|
4.77 KB,
patch
|
jst
:
review+
|
Details | Diff | Splinter Review |
var f1 = document.createDocumentFragment();
f2 = f1.cloneNode(true);
f1.appendChild(document.createElement("foo"));
f1.isEqualNode(f2)
In FF3.6, this returns false.
In FF4.0b7, this returns true, incorrectly.
cc'ing peterv and bzbarsky for bug 560273 and bug 562688, which from hg blame are the most likely to have caused this bug.
I spotted this by code inspection.
|
Reporter | |
Updated•14 years ago
|
blocking2.0: --- → ?
|
Assignee | |
Comment 1•14 years ago
|
||
Ah, definitely a regression from bug 562688.
|
|
Assignee | |
Comment 2•14 years ago
|
||
|
|
Assignee | |
Updated•14 years ago
|
Attachment #492778 -
Flags: review?(jst)
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [need review]
|
||
Updated•14 years ago
|
Attachment #492778 -
Flags: review?(jst) → review+
|
|
||
Updated•14 years ago
|
blocking2.0: ? → final+
|
|
Assignee | |
Updated•14 years ago
|
Attachment #492778 -
Flags: approval2.0?
|
|
Assignee | |
Updated•14 years ago
|
Attachment #492778 -
Flags: approval2.0?
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [need review] → [need landing]
|
||
Updated•14 years ago
|
blocking2.0: final+ → ---
|
|
Assignee | |
Comment 3•14 years ago
|
||
Gavin, please don't remove blocking+ flags? ;)
blocking2.0: --- → final+
|
|
Assignee | |
Comment 4•14 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/2af96a164c62
Status: NEW → RESOLVED
Closed: 14 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [need landing]
Target Milestone: --- → mozilla2.0b8
|
||
Comment 5•14 years ago
|
||
Backed out the patch for being in the range of bug 615736
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [need landing]
|
|
Assignee | |
Comment 6•14 years ago
|
||
Pushed http://hg.mozilla.org/mozilla-central/rev/80426f61cb13 Tree is green.
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•14 years ago
|
Whiteboard: [need landing]
You need to log in
before you can comment on or make changes to this bug.
Description
•