614152 - Context menu does not appear after dismissing notification bar

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Dave Hunt [:davehunt] [he/him] ⌚BST]

This was found whilst investigating Mozmill test failure detailed in bug 613664.

Steps to reproduce:
1. Launch Firefox
2. Turn on Private Browsing
3. Open a page with popups for Firefox to block
4. Use the keyboard shortcut to attempt to allow the popups
5. Hit the ESCAPE key to dismiss the Preferences options
6. Click the Home button
7. Once the page has loaded, right click anywhere in the content

Expected:
Context menu should appear

Actual:
Context menu does not appear

Additional:
* Temporary URL for testing popups: http://blargon7.com/popups/popups_2.html
* Keyboard shortcuts for step 4: accessKey+O (windows), accessKey+P (unix)
* You can also click the back button, etc for step 6. Typing into the address bar will not replicate the issue.
* To recover you just need to type some keys with the address bar focused

This issue first appeared in 2010-08-10

http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fb0c72c4bfb3&tochange=905529619219

From this I suspect bug 572967 as it relates to notification bars persisting.

Comment 1

[Aaron Train [:aaronmt]]

Simplified STR

1. Go to http://www.popuptest.com/popuptest1.html
2. Click Preferences
3. Press Escape
4. Attempt to right click on that page

Comment 2

[Alice0775 White]

Regression window:
Works:
http://hg.mozilla.org/mozilla-central/rev/0f703f93e16a
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b4pre) Gecko/20100808 Minefield/4.0b4pre ID:20100809094906
Fails:
http://hg.mozilla.org/mozilla-central/rev/ed8906789d08
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b4pre) Gecko/20100809 Minefield/4.0b4pre ID:20100809102748
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0f703f93e16a&tochange=ed8906789d08

Regressed by :
ed8906789d08	Neil Deakin — Bug 383930/552341, allow usage of a property on popups instead of using document.popupNode, should fix leak of popupNode, r=neil,sr=roc

Comment 3

[Neil Deakin]

Attachment: Don't set popup node when opening a notification

This should fix the regression. I may want to look at solving this in general for other cases where popupNode might be set manually.

Comment 4

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Attachment: Mozmill tests that reproduces the failure

Added Mozmill test that opens the popup notification menu, navigates to another page, and then verifies that the context menu is not empty for selected text.

Comment 5

[Neil Deakin]

http://hg.mozilla.org/mozilla-central/rev/df43d548da49

Comment 6

[Dave Hunt [:davehunt] [he/him] ⌚BST]

Marking as verified fixed with build: Mozilla/5.0 (Macintosh; Intel Mac OS X
10.6; rv:2.0b8pre) Gecko/20101125 Firefox/4.0b8pre ID: 20101125030318

Comment 7

[ithinc]

(In reply to comment #3)
> This should fix the regression. I may want to look at solving this in general
> for other cases where popupNode might be set manually.

Where is the general fix for other cases where popupNode is set manually?