614382 - Polish the Edit filter dialog on Mac and also fix some obsolete styles (all OS)

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Stefan [:stefanh]]

Basically the same issues as in bug 613358 (mac styling, some obsolete rules)

Comment 1

[Stefan [:stefanh]]

Attachment: v1.0

Just putting it here, need to think a bit about this since it might be an idea to move the .small-button rules to a file that both dialogs (search and filter) can use.

The width of the dialog was hardcoded in the css files, even though we set a width in the xul file (doesn't seem like a good idea either, though). The height is wrong for mac, since there's no room for a scrollbar in the upper listbox, but I figured that it can go in another bug.

Comment 2

[Stefan [:stefanh]]

Attachment: v1.1

-#FilterEditor {
-  width: 560px;
-  min-height:1px;

Not sure why the min-height was there...

Also see bug 620797, button rules are the same here.

Comment 3

[Karsten Düsterloh]

Comment on attachment 499534 [details] [diff] [review]
v1.1

I'm not sure I mentioned that in the search reviews - probably not, because this patch here has the same problem:
if you tab through the dialog, the keyboard focus gets lost (invisible) twice:
- leaving "match" radio group, entering rules area
- leaving rules area, entering actions area

The problem is that the areas themselves get the focus before tabbing gets to their internal elements, so either the area frames should provide visual feedback or (better!) they should not be part of the tab order.

Apart from that, the patch looks fine.

Comment 4

[Stefan [:stefanh]]

(In reply to comment #3)
> Comment on attachment 499534 [details] [diff] [review]
> v1.1
> 
> I'm not sure I mentioned that in the search reviews - probably not, because
> this patch here has the same problem:
> if you tab through the dialog, the keyboard focus gets lost (invisible) twice:
> - leaving "match" radio group, entering rules area
> - leaving rules area, entering actions area

This happens on 2.0.11 too, so it's not caused by the patch. Perhaps we could have a separate bug for it?

Comment 5

[Karsten Düsterloh]

Comment on attachment 499534 [details] [diff] [review]
v1.1

Moved the tabbing issue out to bug 621546.

Comment 6

[Stefan [:stefanh]]

http://hg.mozilla.org/comm-central/rev/8f113735d48c