Polish the Edit filter dialog on Mac and also fix some obsolete styles (all OS)

RESOLVED FIXED in seamonkey2.1b2

Status

SeaMonkey
Themes
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

Trunk
seamonkey2.1b2

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

10.05 KB, patch
Karsten Düsterloh
: review+
Details | Diff | Splinter Review
(Assignee)

Description

7 years ago
Basically the same issues as in bug 613358 (mac styling, some obsolete rules)
(Assignee)

Comment 1

7 years ago
Created attachment 494171 [details] [diff] [review]
v1.0

Just putting it here, need to think a bit about this since it might be an idea to move the .small-button rules to a file that both dialogs (search and filter) can use.

The width of the dialog was hardcoded in the css files, even though we set a width in the xul file (doesn't seem like a good idea either, though). The height is wrong for mac, since there's no room for a scrollbar in the upper listbox, but I figured that it can go in another bug.
(Assignee)

Comment 2

6 years ago
Created attachment 499534 [details] [diff] [review]
v1.1

-#FilterEditor {
-  width: 560px;
-  min-height:1px;

Not sure why the min-height was there...

Also see bug 620797, button rules are the same here.
Attachment #494171 - Attachment is obsolete: true
Attachment #499534 - Flags: review?(mnyromyr)
(Assignee)

Updated

6 years ago
Status: NEW → ASSIGNED
Target Milestone: --- → seamonkey2.1b2

Comment 3

6 years ago
Comment on attachment 499534 [details] [diff] [review]
v1.1

I'm not sure I mentioned that in the search reviews - probably not, because this patch here has the same problem:
if you tab through the dialog, the keyboard focus gets lost (invisible) twice:
- leaving "match" radio group, entering rules area
- leaving rules area, entering actions area

The problem is that the areas themselves get the focus before tabbing gets to their internal elements, so either the area frames should provide visual feedback or (better!) they should not be part of the tab order.

Apart from that, the patch looks fine.
Attachment #499534 - Flags: review?(mnyromyr) → review-
(Assignee)

Comment 4

6 years ago
(In reply to comment #3)
> Comment on attachment 499534 [details] [diff] [review]
> v1.1
> 
> I'm not sure I mentioned that in the search reviews - probably not, because
> this patch here has the same problem:
> if you tab through the dialog, the keyboard focus gets lost (invisible) twice:
> - leaving "match" radio group, entering rules area
> - leaving rules area, entering actions area

This happens on 2.0.11 too, so it's not caused by the patch. Perhaps we could have a separate bug for it?

Comment 5

6 years ago
Comment on attachment 499534 [details] [diff] [review]
v1.1

Moved the tabbing issue out to bug 621546.
Attachment #499534 - Flags: review- → review+
(Assignee)

Comment 6

6 years ago
http://hg.mozilla.org/comm-central/rev/8f113735d48c
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.