[Mac Default] - Use a better focus ring colour in MailNews search dialog

RESOLVED FIXED in seamonkey2.1b2

Status

defect
--
minor
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: stefanh, Assigned: stefanh)

Tracking

Trunk
seamonkey2.1b2
x86
macOS

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

9 years ago
Now that bug 615589 is fixed, we can use the system focus ring colour.

Updated

9 years ago
Status: NEW → ASSIGNED
Assignee

Comment 1

9 years ago
I simplified the style rules a bit - I think this is more manageable. I don't know if it's worth it - but we could put the button rules in a shared css file since the same buttons appear in messenger/filterDialog.css (see bug 614382).
Attachment #499520 - Flags: review?(mnyromyr)
Assignee

Updated

9 years ago
Target Milestone: --- → seamonkey2.1b2
Comment on attachment 499520 [details] [diff] [review]
Use -moz-mac-focusring

The patch has a similar tabbing problem as in bug 614382:
if you tab from the match radio group to the search criteria area, the keyboard focus gets lost (invisible) in between, because the area frame is part of the tab order. Either the area frame needs to give visual feedback or (better!) it should not be part of the tabbing order.

The rest of the patch looks fine!
Attachment #499520 - Flags: review?(mnyromyr) → review-
Assignee

Comment 3

9 years ago
(In reply to comment #2)
> Comment on attachment 499520 [details] [diff] [review]
> Use -moz-mac-focusring
> 
> The patch has a similar tabbing problem as in bug 614382:
> if you tab from the match radio group to the search criteria area, the keyboard
> focus gets lost (invisible) in between, because the area frame is part of the
> tab order. Either the area frame needs to give visual feedback or (better!) it
> should not be part of the tabbing order.

How is this related to the patch? I'm only changing the focus ring colour...
Comment on attachment 499520 [details] [diff] [review]
Use -moz-mac-focusring

Oops, I confused this with bug 613358.
I'll file a new bug for the regression.
Attachment #499520 - Flags: review- → review+
Filed bug 621468.
Not a regression, though.
Assignee

Comment 6

9 years ago
http://hg.mozilla.org/comm-central/rev/e556242a36ef
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.