614501 - "ASSERTION: should only care when we have an outside bullet" with accessibility enabled

Status: NEW

(Core :: Layout, defect)

Description

[Jesse Ruderman]

Attachment: testcase

1. Load the testcase
2. In the JS console, paste
Components.classes["@mozilla.org/accessibilityService;1"]     
.getService(Components.interfaces.nsIAccessibleRetrieval);
3. Focus the testcase(?)

###!!! ASSERTION: should only care when we have an outside bullet: 'mContent->GetPrimaryFrame()->GetStyleDisplay()->mDisplay == NS_STYLE_DISPLAY_LIST_ITEM && HaveOutsideBullet()', file /builds/slave/mozilla-central-linux64-debug/build/layout/generic/nsBlockFrame.cpp, line 6542

Comment 1

[Jesse Ruderman]

Attachment: stack trace

Comment 2

[Boris Zbarsky [:bzbarsky]]

I think BulletIsEmptyExternal() should check for HaveOutsideBullet()...

Comment 3

[alexander :surkov (:asurkov)]

(In reply to comment #2)
> I think BulletIsEmptyExternal() should check for HaveOutsideBullet()...

What is HaveOutsideBullet for?

Comment 4

[Boris Zbarsky [:bzbarsky]]

Bullets can be inside or outside.  See http://www.w3.org/TR/CSS21/generate.html#propdef-list-style-position

Does a11y need to create a bullet accessible in both cases?

Comment 5

[alexander :surkov (:asurkov)]

(In reply to comment #4)

> Does a11y need to create a bullet accessible in both cases?

I think so.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Then it sounds like we need a way to make BulletIsEmpty() work for inside bullets, right?

Comment 7

[alexander :surkov (:asurkov)]

(In reply to comment #6)
> Then it sounds like we need a way to make BulletIsEmpty() work for inside
> bullets, right?

Yes. Btw, what about GetBulletText(), does it work for inside and outside bullets well?

Comment 8

[Boris Zbarsky [:bzbarsky]]

Yes.

For that matter, BulletIsEmpty seems like it should work too, except for the assert bit.