Closed Bug 557795 Opened 14 years ago Closed 14 years ago

wrong list bullet text of accessible for the first numbered HTML:li in CKEditor

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Platform:
All
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla2.0b7

People

(Reporter: surkov, Assigned: surkov)

References

(Depends on 1 open bug, Blocks 1 open bug,
URL
)

Details

(Keywords: access)

Attachments

(2 files)

patch
21.04 KB, patch
davidb
: review+
roc
: superreview+
Details | Diff | Splinter Review
libxul fix
1.86 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review 
create numbered list in CKEditor and inspect the tree, bullet accessible of the first HTML li has "0." accessible name however visually number is 1.

It looks like nsBulletFrame::SetListItemOrdinal() is called after we are notified the HTML li is appended to DOM.
Attached patch patch — — Splinter Review 
Don't cache bullet text, request it when it's necessary. Since accessible events are fired after layout then AT asks for bullet text when it's ready.
Assignee: nobody → surkov.alexander
Status: NEW → ASSIGNED
Attachment #482789 - Flags: superreview?(roc)
Attachment #482789 - Flags: review?(bolterbugz)
Bug 570275 (that has blockign 2.0 status) is going to make things even more worse, all inserted list bullet will have "0. " text. Based on that asking blocking status for this bug as well.
blocking2.0: --- → ?
(In reply to comment #3)
> Bug 570275 (that has blockign 2.0 status) is going to make things even more
> worse,

just fyi, it's just side affect of reworked update tree code and doesn't mean logic in that patch of bug 570275 is wrong.
Attachment #482789 - Flags: superreview?(roc) → superreview+
Attachment #482789 - Flags: review?(bolterbugz) → review+
Blocking approved. I made this block 570275, and status is inherited.
Blocks: 570275
blocking2.0: ? → ---
landed on 2.0 - http://hg.mozilla.org/mozilla-central/rev/9b24526d8132
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b8
non-libxul bustage
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attached patch libxul fix — — Splinter Review 

        Attachment #483151 -
        Flags: review?(roc)

    
  

        Attachment #483151 -
        Attachment is patch: true

        Attachment #483151 -
        Attachment mime type: application/octet-stream → text/plain

    
    

    
  
Comment on attachment 483151 [details] [diff] [review]
libxul fix

r=me

        Attachment #483151 -
        Flags: review?(roc) → review+

    
    

    
  
libxul bustage fix is landed - http://hg.mozilla.org/mozilla-central/rev/5a35da9caa98
Status: REOPENED → RESOLVED
Closed: 14 years ago → 14 years ago
Resolution: --- → FIXED
Target Milestone: mozilla2.0b8 → mozilla2.0b7
Depends on: 614501

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: