614723 - nsSVGFeatures::PassesConditionalProcessingTests doesn't need to get the intl.accept_languages pref on each call

Status: RESOLVED FIXED

(Core :: SVG, defect, P1)

Description

[Boris Zbarsky [:bzbarsky]]

In fact, usually we don't do a language test.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Don't get our acceptLangs unless we plan to use it.

Comment 2

[Jonathan Watt [:jwatt]]

Probably better to use nsContentUtils::RegisterPrefCallback like we do in nsSVGUtils though.

Comment 3

[Boris Zbarsky [:bzbarsky]]

It's a bit of a pain because we end up having to manage the lifetime of a static string....

I can do it if you want, I guess.  But at this point this code only runs if someone is doing filtering on language, right?  Which to a first approximation never happens.

Comment 4

[Jonathan Watt [:jwatt]]

Yeah, never mind that then, I'm sure you have more pressing bugs. ;) I'll file a follow-up.

Comment 5

[Jonathan Watt [:jwatt]]

Filed bug 614819.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 493155 [details] [diff] [review]
Don't get our acceptLangs unless we plan to use it.

Requesting approval. Very safe performance improvement that keeps us from doing ridiculous numbers of localized pref gets during SVG frame construction.

Comment 7

[Jonathan Watt [:jwatt]]

Pushed http://hg.mozilla.org/mozilla-central/rev/21649e5809fb