Closed Bug 614723 Opened 10 years ago Closed 10 years ago
SVGFeatures::Passes Conditional Processing Tests doesn't need to get the intl .accept _languages pref on each call
In fact, usually we don't do a language test.
Priority: -- → P1
Whiteboard: [need review]
Attachment #493155 - Flags: review?(jwatt)
Probably better to use nsContentUtils::RegisterPrefCallback like we do in nsSVGUtils though.
It's a bit of a pain because we end up having to manage the lifetime of a static string.... I can do it if you want, I guess. But at this point this code only runs if someone is doing filtering on language, right? Which to a first approximation never happens.
Yeah, never mind that then, I'm sure you have more pressing bugs. ;) I'll file a follow-up.
Filed bug 614819.
Whiteboard: [need review] → [need approval]
Comment on attachment 493155 [details] [diff] [review] Don't get our acceptLangs unless we plan to use it. Requesting approval. Very safe performance improvement that keeps us from doing ridiculous numbers of localized pref gets during SVG frame construction.
Attachment #493155 - Flags: approval2.0?
Attachment #493155 - Flags: approval2.0? → approval2.0+
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [need approval]
You need to log in before you can comment on or make changes to this bug.