Closed Bug 614723 Opened 9 years ago Closed 9 years ago

nsSVGFeatures::PassesConditionalProcessingTests doesn't need to get the intl.accept_languages pref on each call

Categories

(Core :: SVG, defect, P1)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

Details

Attachments

(1 file)

In fact, usually we don't do a language test.
Priority: -- → P1
Whiteboard: [need review]
Attachment #493155 - Flags: review?(jwatt)
Blocks: 614564
Attachment #493155 - Flags: review?(jwatt) → review+
Probably better to use nsContentUtils::RegisterPrefCallback like we do in nsSVGUtils though.
It's a bit of a pain because we end up having to manage the lifetime of a static string....

I can do it if you want, I guess.  But at this point this code only runs if someone is doing filtering on language, right?  Which to a first approximation never happens.
Yeah, never mind that then, I'm sure you have more pressing bugs. ;) I'll file a follow-up.
Whiteboard: [need review] → [need approval]
Comment on attachment 493155 [details] [diff] [review]
Don't get our acceptLangs unless we plan to use it.

Requesting approval. Very safe performance improvement that keeps us from doing ridiculous numbers of localized pref gets during SVG frame construction.
Attachment #493155 - Flags: approval2.0?
Pushed http://hg.mozilla.org/mozilla-central/rev/21649e5809fb
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Whiteboard: [need approval]
Target Milestone: --- → mozilla2.0b8
Depends on: 829825
No longer depends on: 829825
You need to log in before you can comment on or make changes to this bug.