Closed Bug 614724 Opened 9 years ago Closed 9 years ago

Quickstub createElementNS

Categories

(Core :: DOM: Core & HTML, defect, P1)

x86
macOS
defect

Tracking

()

RESOLVED FIXED
mozilla2.0b8

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

People use this for SVG, say.
Blocks: 614564
Blocks: domperf
Priority: -- → P1
Whiteboard: [need review]
Attachment #493159 - Flags: review?(peterv)
Attachment #493159 - Flags: review?(peterv) → review+
Whiteboard: [need review] → [need approval]
Comment on attachment 493159 [details] [diff] [review]
Quickstub craeteElementNS.

Very simple safe change that speeds up some in-the-wild things using SVG.
Attachment #493159 - Flags: approval2.0?
Attachment #493159 - Flags: approval2.0? → approval2.0+
Whiteboard: [need approval] → [need landing]
Ah, yes.  I don't know why I never ran into that crash locally.  I've pushed the original patch, then a followup for the crash fix (because I pushed the original before seeing comment 3).
Pushed:

  http://hg.mozilla.org/mozilla-central/rev/fa8acee0abe8

and a followup to fix the crash:

  http://hg.mozilla.org/mozilla-central/rev/0418174c8522
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Whiteboard: [need landing]
Target Milestone: --- → mozilla2.0b8
Backed out the patch for being in the range of bug 615736
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [need landing]
Pushed http://hg.mozilla.org/mozilla-central/rev/57aa15b3fce9

(includes the followup already).  Tree is green.
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Whiteboard: [need landing]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.