614969 - Ordered list items with overflow hidden have a zero counter

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Jake Archibald]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10_6_4; en-US) AppleWebKit/534.7 (KHTML, like Gecko) Chrome/7.0.517.44 Safari/534.7
Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0b7) Gecko/20100101 Firefox/4.0b7

If a list item has overflow hidden it gets a counter value of zero. List items with overflow visible are indexed by 1, as if the list-items with overflow hidden weren't there.



Reproducible: Always

Steps to Reproduce:
View http://jsfiddle.net/UtPvk/3/
Actual Results:  
List items are numbered 0 0 1 0 0 2

Expected Results:  
List items numbered 1 2 3 4 5 6

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Bug 272547 seems to have regressed.  (See also bug 4522.)

Comment 2

[Mats Palmgren (inactive)]

It regressed sometime between 2008-09-24 -- 2008-11-09.  (The builds
in between crashes on Linux due to some Pango assertion.)
The culprit appears to be bug 456484, it works if I revert that change.

Comment 3

[Mats Palmgren (inactive)]

Attachment: Patch rev. 1

Comment 4

[Tom Edwards]

display:inline OLs show every item as number 1, related?

e.g. http://developer.valvesoftware.com/wiki/Template:Choreotut

Comment 6

[Boris Zbarsky [:bzbarsky]]

Mats, is that patch ready to go?  If so, request review?

Comment 7

[Mats Palmgren (inactive)]

Attachment: Patch rev. 2

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 522229 [details] [diff] [review]
Patch rev. 2

r=me; want to add a testcase involving a columnset too?

Comment 9

[Mats Palmgren (inactive)]

I added a columnset test but it didn't seem to be affected by the bug.

Fixed in Cedar:
http://hg.mozilla.org/projects/cedar/rev/5cfe5372bd6a

Comment 10

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

http://hg.mozilla.org/mozilla-central/rev/5cfe5372bd6a